mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Lammerts <eric@lammerts.org>
To: Michael Buesch <mbuesch@freenet.de>
Cc: Albert Cahalan <albert@users.sf.net>, Greg KH <greg@kroah.com>,
	Marc Ballarin <Ballarin.Marc@gmx.de>,
	albert@users.sourceforge.net,
	linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: dynamic /dev security hole?
Date: Mon, 9 Aug 2004 13:04:23 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0408091302010.9426@vivaldi.madbase.net> (raw)
In-Reply-To: <200408091854.27019.mbuesch@freenet.de>


On Mon, 9 Aug 2004, Michael Buesch wrote:
> So what about this updated patch?

>  		dbg("unlinking symlink '%s'", filename);
> - -		retval = unlink(filename);
> - -		if (errno == ENOENT)
> - -			retval = 0;
> - -		if (retval) {
> - -			dbg("unlink(%s) failed with error '%s'",
> - -				filename, strerror(errno));
> +		retval = secure_unlink(filename);

Better not do it for symlinks.

Eric

  reply	other threads:[~2004-08-09 17:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-08 12:47 Albert Cahalan
2004-08-08 15:58 ` Marc Ballarin
2004-08-08 15:04   ` Albert Cahalan
2004-08-08 20:42     ` Greg KH
2004-08-08 16:21   ` Greg KH
2004-08-08 21:43     ` Marc Ballarin
2004-08-08 22:07     ` Marc Ballarin
2004-08-09  4:40       ` Eric Lammerts
2004-08-09 13:30         ` Michael Buesch
2004-08-09 13:19           ` Albert Cahalan
2004-08-09 16:54             ` Michael Buesch
2004-08-09 17:04               ` Eric Lammerts [this message]
2004-08-09 17:14                 ` Michael Buesch
2004-08-10  0:21                   ` Greg KH
2004-08-11 17:12             ` [RFC, PATCH] sys_revoke(), just a try. (was: Re: dynamic /dev security hole?) Michael Buesch
2004-08-12 16:49               ` Michael Buesch
2004-08-12 19:51                 ` Alan Cox
2004-08-12 19:39                   ` Albert Cahalan
2004-08-13 12:39                   ` Michael Buesch
2004-08-09 14:49         ` dynamic /dev security hole? Alan Cox
2004-08-09 16:17           ` Eric Lammerts
2004-08-09 15:33             ` Alan Cox
2004-08-09 16:47               ` Eric Lammerts
2004-08-09 17:54                 ` Alan Cox
2004-08-10  0:21       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0408091302010.9426@vivaldi.madbase.net \
    --to=eric@lammerts.org \
    --cc=Ballarin.Marc@gmx.de \
    --cc=albert@users.sf.net \
    --cc=albert@users.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbuesch@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®