From: Dave Airlie <airlied@linux.ie>
To: Christoph Hellwig <hch@infradead.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: drm fixup 1/2 - missing bus_address assignment
Date: Sat, 28 Aug 2004 00:55:32 +0100 (IST) [thread overview]
Message-ID: <Pine.LNX.4.58.0408280054580.23054@skynet> (raw)
In-Reply-To: <20040827152110.A31641@infradead.org>
> > + buf->bus_address = virt_to_bus(buf->address);
>
> this iw wrong. never use virt_to_bus in new code and whenever you see it
> in old code get rid of it.
>
Is there an alternative or do I just dump it? I think we only use the
bus_address for debugging in /proc and I don't think many people actually
have used it ..
Dave.
--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person
next prev parent reply other threads:[~2004-08-27 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 14:12 Dave Airlie
2004-08-27 14:21 ` Christoph Hellwig
2004-08-27 23:55 ` Dave Airlie [this message]
2004-08-28 0:12 ` David S. Miller
2004-08-28 0:16 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0408280054580.23054@skynet \
--to=airlied@linux.ie \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®