mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@linux.ie>
To: davem@redhat.com, linux-kernel@vger.kernel.org
Subject: ffb drm dead code removal..
Date: Sun, 29 Aug 2004 13:45:14 +0100 (IST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0408291342170.3682@skynet> (raw)


Dave,
	I want to apply the following to the ffb DRM it is dead code as
the DRM doesn't use the macro anymore... if you have no issues I'll send
it on to Linus..

I've no way to build the ffb driver at all at the moment, if anyone builds
sparc kernels with ffb regularly I don't suppose you could checkout DRM
cvs and build it against the kernel to see if it still builds...

Dave.

diff -Nru a/drivers/char/drm/ffb_drv.c b/drivers/char/drm/ffb_drv.c
--- a/drivers/char/drm/ffb_drv.c	Sun Aug 29 22:39:49 2004
+++ b/drivers/char/drm/ffb_drv.c	Sun Aug 29 22:39:49 2004
@@ -40,7 +40,6 @@
 	.get_unmapped_area	= ffb_get_unmapped_area,		\
 }

-#define DRIVER_COUNT_CARDS()	ffb_count_card_instances()
 /* Allocate private structure and fill it */
 #define DRIVER_PRESETUP()	do {		\
 	int _ret;				\
@@ -220,34 +219,6 @@
 }

 static int ffb_presetup(drm_device_t *);
-
-static int __init ffb_count_card_instances(void)
-{
-	int root, total, instance;
-
-	total = ffb_count_siblings(prom_root_node);
-	root = prom_getchild(prom_root_node);
-	for (root = prom_searchsiblings(root, "upa"); root;
-	     root = prom_searchsiblings(prom_getsibling(root), "upa"))
-		total += ffb_count_siblings(root);
-
-	ffb_position = kmalloc(sizeof(ffb_position_t) * total, GFP_KERNEL);
-
-	/* Actual failure will be caught during ffb_presetup b/c we can't catch
-	 * it easily here.
-	 */
-	if (!ffb_position)
-		return -ENOMEM;
-
-	instance = ffb_scan_siblings(prom_root_node, 0);
-
-	root = prom_getchild(prom_root_node);
-	for (root = prom_searchsiblings(root, "upa"); root;
-	     root = prom_searchsiblings(prom_getsibling(root), "upa"))
-		instance = ffb_scan_siblings(root, instance);
-
-	return total;
-}

 static drm_map_t *ffb_find_map(struct file *filp, unsigned long off)
 {

             reply	other threads:[~2004-08-29 12:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-29 12:45 Dave Airlie [this message]
2004-08-29 17:44 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0408291342170.3682@skynet \
    --to=airlied@linux.ie \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®