Re: [RFC] DRM remove DMA/IRQ macros..

[Dave Airlie <airlied@linux.ie>]

Thanks Dave, I'll look into it, I've no way to build or test the ffb (I'm
not even sure the user space code works anymore), so I rely on feedback
for it from others..

Dave.

On Sun, 5 Sep 2004, David S. Miller wrote:

> On Sun, 5 Sep 2004 10:21:34 +0100 (IST)
> Dave Airlie <airlied@linux.ie> wrote:
>
> > 	The attached patch dumps the DMA/IRQ macros, I've realised I one
> > more to go after this for some macros from the ffb driver,
>
>
> Speaking of the ffb driver, you broke the build of
> it pretty seriously 2 days ago, please fix.  Thanks.
>
> drivers/char/drm/ffb_drv.c: At top level:
> drivers/char/drm/ffb_drv.c:296: warning: `ffb_presetup' defined but not used
> drivers/char/drm/ffb_drv.c:179: warning: `ffb_count_card_instances' defined but not used
>   CC [M]  drivers/char/drm/ffb_context.o
> drivers/char/drm/ffb_context.c: In function `ffb_driver_presetup':
> drivers/char/drm/ffb_context.c:559: warning: implicit declaration of function `ffb_presetup'
> drivers/char/drm/ffb_context.c:560: error: `_ret' undeclared (first use in this function)
> drivers/char/drm/ffb_context.c:560: error: (Each undeclared identifier is reported only once
> drivers/char/drm/ffb_context.c:560: error: for each function it appears in.)
> drivers/char/drm/ffb_context.c: In function `ffb_driver_postcleanup':
> drivers/char/drm/ffb_context.c:570: error: `ffb_position' undeclared (first use in this function)
> drivers/char/drm/ffb_context.c: In function `ffb_driver_kernel_context_switch_unlock':
> drivers/char/drm/ffb_context.c:580: error: `lock' undeclared (first use in this function)
> drivers/char/drm/ffb_context.c: At top level:
> drivers/char/drm/ffb_context.c:591: warning: static declaration for `ffb_driver_register_fns' follows non-static
> drivers/char/drm/ffb_context.c: In function `ffb_driver_register_fns':
> drivers/char/drm/ffb_context.c:593: warning: assignment from incompatible pointer type
> drivers/char/drm/ffb_context.c:596: warning: assignment from incompatible pointer type
> drivers/char/drm/ffb_context.c: At top level:
> drivers/char/drm/ffb_context.c:591: warning: `ffb_driver_register_fns' defined but not used
>

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person