From: Linus Torvalds <torvalds@osdl.org>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Steve French <smfltc@us.ibm.com>
Subject: Re: [PATCH 4/4] copyfile: copyfile
Date: Tue, 7 Sep 2004 08:28:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0409070826550.2299@ppc970.osdl.org> (raw)
In-Reply-To: <20040907152118.GA30396@wohnheim.fh-wedel.de>
On Tue, 7 Sep 2004, Jörn Engel wrote:
>
> > Actually, the 4kB batching one was - if you only max out to using 4kB at a
> > time, sendfile() is kind of pointless, because then it will never do
> > multi-page copies in the first place, and all the complexity at a lower
> > level is worthless..
>
> Give me a better number. 16k? 1M? Or would it not be fundamentally
> flawed if the unit was seconds, instead of bytes? That makes a lot
> more sense, since a floppy and a Ultra320 RAID array differ slightly
> in speed and it's response time the users actually care about.
Well, you can't do it by seconds. What you _can_ do is to just make the
fundamental page-cache sendfile thing check for interruptible, and just do
it at a lower level. Maybe.
Linus
next prev parent reply other threads:[~2004-09-07 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 12:09 [PATCH 1/4] copyfile: generic_sendpage Jörn Engel
2004-09-07 12:11 ` [PATCH 2/4] copyfile: sendfile Jörn Engel
2004-09-07 12:12 ` [PATCH 3/4] copyfile: sendfile_loop Jörn Engel
2004-09-07 12:15 ` [PATCH 4/4] copyfile: copyfile Jörn Engel
2004-09-07 14:06 ` Linus Torvalds
2004-09-07 14:19 ` Anton Altaparmakov
2004-09-07 14:51 ` Jörn Engel
2004-09-07 14:59 ` Linus Torvalds
2004-09-07 15:21 ` Jörn Engel
2004-09-07 15:28 ` Linus Torvalds [this message]
2004-09-09 15:04 ` Herbert Poetzl
2004-09-08 17:09 ` Steve French
2004-09-07 15:32 ` [PATCH 1/4] copyfile: generic_sendpage David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0409070826550.2299@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=smfltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®