From: Dave Airlie <airlied@linux.ie>
To: Christoph Hellwig <hch@infradead.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [BK tree] [drm] remove counter macros..
Date: Tue, 21 Sep 2004 13:21:38 +0100 (IST) [thread overview]
Message-ID: <Pine.LNX.4.58.0409211316310.22187@skynet> (raw)
In-Reply-To: <20040921130936.A22429@infradead.org>
Well this was only a direct macro removal, I'm contemplating removing the
counters as to be honest I'm not sure any drm developer as actually used
them since day one .. (and maybe not even then)... but I'll leave that for
another time, as there might be a wierd use of them somewhere...
Once I drop the ioctl macro, I'll probably start going back to see what
stuff is probably not of any use anymore.. (counters are fairly high on
that list..)..
Dave.
On Tue, 21 Sep 2004, Christoph Hellwig wrote:
> While I definitly approve this patch is there a specific reason for this
> array instead of individual members like
>
> lock_cnt, open_cnt, close_cnt, etc..?
>
> also the optional counters seem to be largely overlapping, why not always
> all four thta exist and if some drivers don't want to update them they'd
> just not update them
>
--
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person
next prev parent reply other threads:[~2004-09-21 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 10:50 Dave Airlie
2004-09-21 12:09 ` Christoph Hellwig
2004-09-21 12:21 ` Dave Airlie [this message]
2004-09-21 12:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0409211316310.22187@skynet \
--to=airlied@linux.ie \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®