From: Ingo Molnar <mingo@redhat.com>
To: Con Kolivas <kernel@kolivas.org>
Cc: "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
linux-kernel@vger.kernel.org, "Andrew Morton" <akpm@osdl.org>
Subject: Re: bug in sched.c:activate_task()
Date: Tue, 5 Oct 2004 02:54:47 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0410050250580.4941@devserv.devel.redhat.com> (raw)
In-Reply-To: <cone.1096958170.135056.10082.502@pc.kolivas.org>
On Tue, 5 Oct 2004, Con Kolivas wrote:
> unsigned long long delta = now - next->timestamp;
>
> if (next->activated == 1)
> delta = delta * (ON_RUNQUEUE_WEIGHT * 128 / 100) / 128;
>
> is in schedule() before we update the timestamp, no?
indeed ... so the patch is just random incorrect damage that happened to
distrub the scheduler fixing some balancing problem. Kenneth, what
precisely is the balancing problem you are seeing?
Ingo
next prev parent reply other threads:[~2004-10-05 6:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 2:16 Chen, Kenneth W
2004-10-05 2:34 ` Con Kolivas
2004-10-05 3:14 ` Nick Piggin
2004-10-05 4:45 ` Con Kolivas
2004-10-05 5:05 ` Peter Williams
2004-10-05 6:10 ` Nick Piggin
2004-10-05 6:31 ` Ingo Molnar
2004-10-05 6:36 ` Con Kolivas
2004-10-05 6:54 ` Ingo Molnar [this message]
2004-10-05 6:59 ` Con Kolivas
2004-10-05 7:08 ` Nick Piggin
2004-10-05 7:09 ` Ingo Molnar
2004-10-05 17:30 ` Chen, Kenneth W
2004-10-05 17:25 ` Chen, Kenneth W
2004-10-05 6:57 ` Nick Piggin
2004-10-05 8:19 ` Ingo Molnar
2004-10-05 17:44 ` Chen, Kenneth W
2004-10-05 22:46 Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0410050250580.4941@devserv.devel.redhat.com \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome