From: Linus Torvalds <torvalds@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] pmac_cpufreq msleep cleanup/fixes
Date: Fri, 22 Oct 2004 15:53:38 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0410221552320.2101@ppc970.osdl.org> (raw)
In-Reply-To: <1098484616.6028.80.camel@gaston>
On Sat, 23 Oct 2004, Benjamin Herrenschmidt wrote:
>
> Please revert that change until we have made absolutely sure that msleep(1)
> on a HZ=1000 machine will actually sleep at least 1ms, this is really not
> clear since it will end up doing schedule_timeout(1) which, afaik, will
> only guarantee to sleep up to the next jiffie, which can be a lot shorter
> than the actual duration of a jiffie.
In that case I'd much prefer to revert the whole previous "cleanup" as
well, since it obviously isn't really. Having
msleep(1 + jiffy_to_ms(1));
is just not a cleanup to me.
Linus
next prev parent reply other threads:[~2004-10-22 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200410221906.i9MJ63Ai022889@hera.kernel.org>
2004-10-22 22:36 ` Benjamin Herrenschmidt
2004-10-22 22:53 ` Linus Torvalds [this message]
2004-10-22 23:17 ` Benjamin Herrenschmidt
2004-10-22 23:43 ` Nishanth Aravamudan
2004-10-23 0:33 ` Paul Mackerras
2004-10-22 23:51 ` Linus Torvalds
2004-10-25 0:19 ` [PATCH][RESEND] Fix msleep to sleep _at_least_ the requested amount Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0410221552320.2101@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®