mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>, linux-kernel@vger.kernel.org
Subject: Re: RFC: Changes to fs/buffer.c?
Date: Fri, 29 Oct 2004 13:45:50 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0410291343510.28839@ppc970.osdl.org> (raw)
In-Reply-To: <20041029133420.76a758b3.akpm@osdl.org>



On Fri, 29 Oct 2004, Andrew Morton wrote:
>
> Anton Altaparmakov <aia21@cam.ac.uk> wrote:
> >
> > Is it ok to export 
> >  create_buffers() and to make __set_page_buffers() static inline and move 
> >  it to include/linux/buffer.h?
> 
> ho, hum - if you must ;)
> 
> I'd be inclined to rename it to attach_page_buffers() or something though -
> create_buffers() is a bit generic-sounding.

Also, I think we should at least start out limiting it to GPL-only usage. 
Those page buffers are pretty intertwined with the VM usage, I'd hate to 
see people think this is some kind of external interface..

		Linus

  reply	other threads:[~2004-10-29 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 14:28 Anton Altaparmakov
2004-10-29 20:34 ` Andrew Morton
2004-10-29 20:45   ` Linus Torvalds [this message]
2004-10-29 21:48     ` Anton Altaparmakov
2004-10-29 21:46   ` Anton Altaparmakov
2004-11-01 22:42     ` [PATCH 2.6] " Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0410291343510.28839@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®