mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, Paul Mackerras <paulus@samba.org>,
	Anton Blanchard <anton@samba.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] PPC64 mmu_context_init needs to run earlier
Date: Tue, 2 Nov 2004 14:10:35 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0411021406010.2187@ppc970.osdl.org> (raw)
In-Reply-To: <1099432625.23845.93.camel@pants.austin.ibm.com>



On Tue, 2 Nov 2004, Nathan Lynch wrote:
> 
> Using idr_get_new_above in init_new_context lets us get rid of an
> awkward init function which wasn't running early enough in boot
> anyway.

Ok, call me stupid, but what's the difference between

	idr_get_new(&mmu_context_idr, NULL, &index);

and

	idr_get_new_above(&mmu_context_idr, NULL, 0, &index);

because as far as I can tell, they are exactly the same.

They both just do a "idr_get_new_above_int(idp, ptr, 0)".

So I don't see why one would need an awkward init function, and the other
wouldn't..

That said, maybe the problem is that we shouldn't even get far enough into 
the fork() logic to ever get into a new MMU context if driver_init ends up 
being called before we're ready. 

		Linus

  reply	other threads:[~2004-11-02 22:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-02  5:11 Paul Mackerras
2004-11-02  6:13 ` Andrew Morton
2004-11-02 21:57   ` Nathan Lynch
2004-11-02 22:10     ` Linus Torvalds [this message]
2004-11-02 23:35       ` Benjamin Herrenschmidt
2004-11-03  0:08       ` Nathan Lynch
2004-11-03 23:04 ` Andrew Morton
2004-11-04  2:53   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0411021406010.2187@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathanl@austin.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®