mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Sergey Vlasov <vsu@altlinux.ru>
Cc: ierdnah <ierdnah@go.ro>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kernel oops!
Date: Sun, 23 Jan 2005 10:22:53 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0501230956100.4191@ppc970.osdl.org> (raw)
In-Reply-To: <20050123161512.149cc9de.vsu@altlinux.ru>



On Sun, 23 Jan 2005, Sergey Vlasov wrote:
> 
> tty_poll() grabs ldisc reference for the tty it was called with;
> however, in this case pty_chars_in_buffer() accesses another ldisc
> (tty->link->ldisc) without grabbing a reference to it.  BTW, many other
> pty_* functions do the same thing.

Yes, I think you put the finger on it.

> Is calling tty_ldisc_ref(tty->link) safe here?  There is a comment
> warning about possible deadlocks before pty_write().

I think it's only the tty_ldisc_ref_wait() thing that can deadlock (and 
even that is likely safe if you just specify an order - "masters first" or 
something). Adding a nonblocking "tty_ldisc_ref()" looks safe, ie 
something like the appended.

This has the problem (apart from the fact that it's obviously totally
untested ;) that it looks like every single pty function would need to do
it, so it would be nicer if "tty_ldisc_ref_wait()" would just always get
both references (ie do the ordering). Alan?

		Linus
----
--- 1.32/drivers/char/pty.c	2005-01-10 17:29:36 -08:00
+++ edited/drivers/char/pty.c	2005-01-23 10:21:04 -08:00
@@ -149,13 +149,17 @@
 static int pty_chars_in_buffer(struct tty_struct *tty)
 {
 	struct tty_struct *to = tty->link;
-	int count;
+	int count = 0;
 
-	if (!to || !to->ldisc.chars_in_buffer)
-		return 0;
-
-	/* The ldisc must report 0 if no characters available to be read */
-	count = to->ldisc.chars_in_buffer(to);
+	if (to) {
+		struct tty_ldisc *ld = tty_ldisc_ref(to);
+		if (ld) {
+			if (ld->chars_in_buffer) {
+				count = ld->chars_in_buffer(to);
+				tty_ldisc_deref(ld);
+			}
+		}
+	}
 
 	if (tty->driver->subtype == PTY_TYPE_SLAVE) return count;
 

  reply	other threads:[~2005-01-23 18:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-22 23:36 ierdnah
2005-01-23  6:43 ` Linus Torvalds
2005-01-23 12:29   ` ierdnah
2005-01-23 17:51     ` Linus Torvalds
2005-01-24 19:21       ` ierdnah
2005-01-27 22:47       ` ierdnah
2005-01-27 23:35         ` Linus Torvalds
2005-01-28 20:00           ` ierdnah
2005-01-28 20:28             ` Linus Torvalds
2005-01-28 22:22               ` ierdnah
2005-01-23 13:15   ` Sergey Vlasov
2005-01-23 18:22     ` Linus Torvalds [this message]
2005-01-24 15:44       ` Alan Cox
2005-01-24 17:58         ` Linus Torvalds
2005-01-24 18:09           ` Alan Cox
2005-01-24 15:44     ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2008-01-07 23:15 Kernel Oops? Stoyan Gaydarov
2008-01-07 23:30 ` Alan Cox
2008-01-09  2:25   ` Stoyan Gaydarov
2008-01-09  3:02     ` Alan Cox
2008-01-09  3:24       ` Stoyan Gaydarov
2008-01-10 23:05         ` Jesper Juhl
2008-01-07 23:34 ` Jesper Juhl
2004-09-17 14:05 kernel Oops!!!! Jysuis Parla
2004-09-17 14:05 Jysuis Parla
2004-09-17 17:30 ` Gene Heskett
     [not found] <3A08FA77.703BCC07@rdstm.ro>
2000-11-08 16:29 ` Kernel oops! Venky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0501230956100.4191@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ierdnah@go.ro \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vsu@altlinux.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®