mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter Münster" <pmlists@free.fr>
To: linux-kernel@vger.kernel.org
Cc: acpi-devel@lists.sourceforge.net, axboe@suse.de,
	benh@kernel.crashing.org, B.Zolnierkiewicz@elka.pw.edu.pl
Subject: [Patch] keep ide disk sleeping when resuming
Date: Wed, 2 Feb 2005 20:47:31 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.58.0502022006030.4130@gaston.free.fr> (raw)

Hello,

I need this patch (against linux-2.6.11-rc2), to keep ide disk sleeping,
when resuming from ACPI S1.

In fact, it's just removing a patch from 22 Jun 2004 by Jens Axboe. He has
told me, that "We can probably kill the patch completely".
So, this is what I'm doing now.

Kind regards, Peter

--- drivers/ide/ide-disk.c.orig	2005-02-02 20:30:12.000000000 +0100
+++ drivers/ide/ide-disk.c	2005-02-02 20:32:21.000000000 +0100
@@ -864,9 +864,7 @@
 enum {
 	idedisk_pm_flush_cache	= ide_pm_state_start_suspend,
 	idedisk_pm_standby,
-
-	idedisk_pm_idle		= ide_pm_state_start_resume,
-	idedisk_pm_restore_dma,
+	idedisk_pm_restore_dma	= ide_pm_state_start_resume
 };
 
 static void idedisk_complete_power_step (ide_drive_t *drive, struct request *rq, u8 stat, u8 error)
@@ -881,9 +879,6 @@
 	case idedisk_pm_standby:	/* Suspend step 2 (standby) complete */
 		rq->pm->pm_step = ide_pm_state_completed;
 		break;
-	case idedisk_pm_idle:		/* Resume step 1 (idle) complete */
-		rq->pm->pm_step = idedisk_pm_restore_dma;
-		break;
 	}
 }
 
@@ -914,12 +909,6 @@
 		args->handler	   = &task_no_data_intr;
 		return do_rw_taskfile(drive, args);
 
-	case idedisk_pm_idle:		/* Resume step 1 (idle) */
-		args->tfRegister[IDE_COMMAND_OFFSET] = WIN_IDLEIMMEDIATE;
-		args->command_type = IDE_DRIVE_TASK_NO_DATA;
-		args->handler = task_no_data_intr;
-		return do_rw_taskfile(drive, args);
-
 	case idedisk_pm_restore_dma:	/* Resume step 2 (restore DMA) */
 		/*
 		 * Right now, all we do is call hwif->ide_dma_check(drive),

-- 
http://pmrb.free.fr/contact/

             reply	other threads:[~2005-02-02 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 19:47 Peter Münster [this message]
2005-02-02 23:38 ` [ACPI] " Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0502022006030.4130@gaston.free.fr \
    --to=pmlists@free.fr \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=axboe@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®