mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andi Kleen <ak@suse.de>, Ingo Molnar <mingo@elte.hu>,
	Christoph Hellwig <hch@infradead.org>,
	akpm@osdl.org, linux-kernel@vger.kernel.org, drepper@redhat.com
Subject: Re: [PROPOSAL/PATCH] Remove PT_GNU_STACK support before 2.6.11
Date: Sun, 6 Feb 2005 09:31:20 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0502060920050.2165@ppc970.osdl.org> (raw)
In-Reply-To: <1107710023.22680.138.camel@laptopd505.fenrus.org>



On Sun, 6 Feb 2005, Arjan van de Ven wrote:
> 
> Note that these techniques all exist today. The only issue is that the
> current code doesn't do the RWE->READIMPLIESEXEC binding, which my patch
> fixed. 

My main objection to your patch is the naming. If 'executable_stack' 
affects the heap, then why is it called "executable_STACK"?

Wouldn't it be much nicer to

 - get rid of "EXSTACK_DEFAULT" as a special case, and instead just have 
   the architecture _initialize_ the damn variable to what it wants? In 
   other words, make it a nice understandable binary value (or maybe a 
   bitmask, if you want to have separate flags for stack/heap/mmap), 
   rather than a ternary value where one of the values means something 
   arch-dependent.

 - just rename the dang thing to "read_implies_exec" and be done with it?

Hmm? Wouldn't that make a lot more sense?

And if you want to split things up, there's at least three flags there:  
"stack" vs "file mapping" vs "anonymous mapping". For example, it might
well make sense to enforce PROT_EXEC on real file mappings, but not on the
stack or heap..  So "read_implies_exec" might well be a collection of bits 
to enable these one by one (and make the "legacy app" thing make it enable 
read-implies-exec for all the cases).

		Linus

  reply	other threads:[~2005-02-06 17:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-06 11:36 Andi Kleen
2005-02-06 11:47 ` Arjan van de Ven
2005-02-06 12:02   ` Ingo Molnar
2005-02-06 12:25     ` Ingo Molnar
2005-02-06 12:36     ` Andi Kleen
2005-02-06 12:45     ` Ingo Molnar
2005-02-06 12:50       ` Andi Kleen
2005-02-06 12:59         ` Arjan van de Ven
2005-02-06 13:01           ` Andi Kleen
2005-02-06 13:04             ` Arjan van de Ven
2005-02-06 13:09               ` Andi Kleen
2005-02-06 13:31                 ` Ingo Molnar
2005-02-06 13:43                   ` Andi Kleen
2005-02-06 13:06             ` Christoph Hellwig
2005-02-06 13:11               ` Andi Kleen
2005-02-06 13:32                 ` Ingo Molnar
2005-02-06 13:46                   ` Andi Kleen
2005-02-06 14:08                     ` Ingo Molnar
2005-02-06 14:22                       ` Ingo Molnar
2005-02-06 14:29                       ` Andi Kleen
2005-02-06 17:08                         ` Linus Torvalds
2005-02-06 17:13                           ` Arjan van de Ven
2005-02-06 17:31                             ` Linus Torvalds [this message]
2005-02-06 17:39                               ` Arjan van de Ven
2005-02-06 18:04                                 ` Linus Torvalds
2005-02-06 18:08                                   ` Arjan van de Ven
2005-02-06 17:56                           ` Andi Kleen
2005-02-06 12:33   ` Andi Kleen
2005-02-06 12:40     ` Arjan van de Ven
2005-02-06 12:48       ` Andi Kleen
2005-02-06 15:54         ` Andreas Schwab
2005-02-06 17:05     ` Linus Torvalds
2005-02-06 17:58       ` Andi Kleen
2005-02-06 12:11 ` Paweł Sikora
     [not found] ` <200502061303.12377.pluto@pld-linux.org>
     [not found]   ` <20050206124701.GD30109@wotan.suse.de>
2005-02-06 18:07     ` Paweł Sikora
2005-02-06 18:38       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0502060920050.2165@ppc970.osdl.org \
    --to=torvalds@osdl.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=drepper@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®