From: Linus Torvalds <torvalds@osdl.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Roman Zippel <zippel@linux-m68k.org>,
Andreas Schwab <schwab@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: Pty is losing bytes
Date: Wed, 16 Feb 2005 08:06:00 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0502160802510.2383@ppc970.osdl.org> (raw)
In-Reply-To: <20050216144203.GB7767@thunk.org>
On Wed, 16 Feb 2005, Theodore Ts'o wrote:
>
> The comment above the test explains why that test is there in
> n_tty_receive_room. If that test isn't there, and we are doing input
> canonicalization, when the buffer gets full
Yes, yes, but did you see my suggested version that I had just below that
explained what I thought the real fix was?
Th eproblem with checking for the "canon but no canon data" is that it's a
special case that IS ONLY VALID WHEN THE BUFFER IS FULL! Until that
happens, it means that the code returns the wrong value, and then can
(obviously, as seen by the bug) drop bytes even when it shouldn't.
That's why my suggested work-around moved things around, to only return
the "we'll take anything" thing if the buffer really was full.
Linus
next prev parent reply other threads:[~2005-02-16 16:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-15 0:54 Andreas Schwab
2005-02-15 19:08 ` Linus Torvalds
2005-02-15 19:44 ` Linus Torvalds
2005-02-15 22:13 ` Alan Cox
2005-02-15 19:58 ` Sergey Vlasov
2005-02-15 20:13 ` Sergey Vlasov
2005-02-15 20:06 ` Alan Curry
2005-02-15 20:30 ` Andreas Schwab
2005-02-15 20:56 ` Linus Torvalds
2005-02-15 21:54 ` Andreas Schwab
2005-02-16 3:12 ` Roman Zippel
2005-02-16 4:05 ` Linus Torvalds
2005-02-16 14:42 ` Theodore Ts'o
2005-02-16 16:06 ` Linus Torvalds [this message]
2005-02-17 4:44 ` Theodore Ts'o
2005-02-17 15:45 ` Linus Torvalds
2005-02-18 16:32 ` Theodore Ts'o
2005-02-16 19:49 ` Roman Zippel
2005-02-16 19:58 ` Linus Torvalds
2005-02-16 22:46 ` Andrew Morton
2005-02-15 2:00 Alex Davis
2005-02-15 10:48 ` Andreas Schwab
2005-02-15 11:01 ` Jan De Luyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0502160802510.2383@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=tytso@mit.edu \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®