From: Linus Torvalds <torvalds@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>, Greg KH <gregkh@suse.de>
Subject: Re: IBM Thinkpad G41 PCMCIA problems [Was: Yenta TI: ... no PCI interrupts. Fish. Please report.]
Date: Sun, 20 Feb 2005 09:23:56 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0502200905060.2378@ppc970.osdl.org> (raw)
In-Reply-To: <20050220082226.A7093@flint.arm.linux.org.uk>
On Sun, 20 Feb 2005, Russell King wrote:
> On Sat, Feb 19, 2005 at 08:36:12PM -0500, Steven Rostedt wrote:
> > BIOS-e820: 0000000000000000 - 000000000009f000 (usable)
> > BIOS-e820: 000000000009f000 - 00000000000a0000 (reserved)
> > BIOS-e820: 00000000000d0000 - 00000000000d4000 (reserved)
> > BIOS-e820: 00000000000dc000 - 0000000000100000 (reserved)
> > BIOS-e820: 0000000000100000 - 000000000f6f0000 (usable)
> > BIOS-e820: 000000000f6f0000 - 000000000f700000 (reserved)
> > BIOS-e820: 000000000f700000 - 000000003fef0000 (usable)
> > BIOS-e820: 000000003fef0000 - 000000003fef8000 (ACPI data)
> > BIOS-e820: 000000003fef8000 - 000000003fefa000 (ACPI NVS)
> > BIOS-e820: 000000003ff00000 - 0000000040000000 (reserved)
>
> Your BIOS is broken. You probably have 1GB of RAM which extends from
> 0x00000000 to 0x40000000. However, there's a hole in the ACPI map
> between 0x3fefa000 and 0x3ff00000.
Good point. And dammit, we've had that problem too many times before.
And I think the reason for that bug is that we use "max_low_pfn" to
determine where we should start allocating PCI memory. We actually round
it up to the next megabyte, which _should_ have made us not allocate in
that small region (the last usable page is 0x3fef0000, rounded up to the
nearest megabyte is 0x3ff00000, which is marked as "reserved", so we
_should_ have allocated above that quite nicely).
However, we are screwed by the fact that "max_low_pfn" is actually limited
by MAXMEM_PFN, which is the kernel _mappable_ memory, so MAXMEM is
actually much less than one megabyte (it's one megabyte minus
"VMALLOC_RESERVE", which defaults to 128MB).
But the PCI allocations are not at all limited by MAXMEM - they want to be
in the low 4GB, but that's the only real limit. So using "max_low_pfn" to
determine where to start PCI allocations is pretty bogus.
I'll try to write something that actually looks at the e820 memory map
properly.
Linus
next prev parent reply other threads:[~2005-02-20 17:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-20 0:22 Steven Rostedt
2005-02-20 0:59 ` Linus Torvalds
2005-02-20 1:36 ` Steven Rostedt
2005-02-20 2:10 ` Linus Torvalds
2005-02-20 3:38 ` Steven Rostedt
2005-02-20 4:02 ` Linus Torvalds
2005-03-12 3:31 ` Adam Belay
2005-02-20 6:51 ` Linus Torvalds
2005-02-20 7:06 ` Linus Torvalds
2005-02-20 11:48 ` Steven Rostedt
2005-02-20 8:22 ` Russell King
2005-02-20 10:20 ` Russell King
2005-02-20 11:59 ` Steven Rostedt
2005-02-20 11:54 ` Steven Rostedt
2005-02-20 17:23 ` Linus Torvalds [this message]
2005-02-20 17:56 ` Linus Torvalds
2005-02-20 21:26 ` IBM Thinkpad G41 PCMCIA problems [Was: Yenta TI: ... no PCI David Härdeman
2005-02-21 4:19 ` IBM Thinkpad G41 PCMCIA problems [Was: Yenta TI: ... no PCI interrupts. Fish. Please report.] Steven Rostedt
2005-03-12 3:36 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0502200905060.2378@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®