From: Linus Torvalds <torvalds@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Norbert Preining <preining@logic.at>,
linux-kernel@vger.kernel.org,
Zwane Mwaikambo <zwane@holomorphy.com>
Subject: Re: 2.6.11-rc2-mm1 strange messages
Date: Thu, 24 Feb 2005 22:12:56 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0502242210360.9237@ppc970.osdl.org> (raw)
In-Reply-To: <20050224181412.64a1f351.akpm@osdl.org>
On Thu, 24 Feb 2005, Andrew Morton wrote:
>
> Although a better fix might be to make __iounmap() behave symmetrically:
>
> if ((long)addr >= phys_to_virt(0xA0000) &&
> (long)addr < phys_to_virt(0x100000))
> return;
>
> but that's not quite right, because we're assuming that the range to be
> unmapped is wholly within the PCI/ISA region. Without a VMA there just
> isn't enough info to determine that.
>
> Does anyone have any preferences?
I think the "as symmetric as possible" thing is probably the thing to do.
It might not be perfect in theory, but hey, practice is what matters. And
in practice it's the "right thing", I think.
Linus
next prev parent reply other threads:[~2005-02-25 6:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-25 12:17 Norbert Preining
2005-01-25 18:28 ` Andrew Morton
2005-01-27 0:01 ` Len Brown
2005-01-27 6:24 ` Norbert Preining
2005-02-24 14:10 ` Norbert Preining
2005-02-24 23:03 ` Andrew Morton
2005-02-25 1:23 ` Norbert Preining
2005-02-25 2:14 ` Andrew Morton
2005-02-25 6:12 ` Linus Torvalds [this message]
2005-02-25 6:33 ` Andrew Morton
2005-02-25 9:15 ` Norbert Preining
2005-02-25 9:52 ` Andrew Morton
2005-02-25 13:27 ` Norbert Preining
[not found] ` <1106679006.11688.26.camel@localhost.localdomain>
2005-01-27 12:52 ` Norbert Preining
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0502242210360.9237@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=preining@logic.at \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®