From: Linus Torvalds <torvalds@osdl.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: nuclearcat <nuclearcat@nuclearcat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: pty_chars_in_buffer NULL pointer (kernel oops)
Date: Fri, 25 Feb 2005 19:42:00 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0502251935420.9237@ppc970.osdl.org> (raw)
In-Reply-To: <20050225230432.GD15251@logos.cnet>
On Fri, 25 Feb 2005, Marcelo Tosatti wrote:
>
> BTW, I fail to see any drivers/char/pty.c change related to the race which triggers
> the pty_chars_in_buffer->0 oops.
Indeed, I don't think 2.6.x got that merged, because it was never really
clear _which_ fix was the right one (the extra locking was absolutely
deadly for performance, the hacky one was a tad _too_ hacky ;)
Alan, did you ever decide what the proper locking would be? I've applied
the hacky "works by hiding the problem" patch for 2.6.11 which didn't have
any subtle performance issues associated with it.
Linus
next prev parent reply other threads:[~2005-02-26 3:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 8:56 nuclearcat
2005-02-25 23:04 ` Marcelo Tosatti
2005-02-26 3:42 ` Linus Torvalds [this message]
2005-02-26 11:18 ` Alan Cox
2005-02-27 14:52 ` Re[2]: " nuclearcat
2005-02-27 15:03 ` Re[3]: " nuclearcat
2005-02-27 10:00 Marcelo Tosatti
2005-02-27 19:46 ` Linus Torvalds
2005-04-13 18:43 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0502251935420.9237@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nuclearcat@nuclearcat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®