From: Linus Torvalds <torvalds@osdl.org>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ReiserFS List <reiserfs-list@namesys.com>
Subject: Re: [PATCH/URL] reiserfs: reformat code with Lindent
Date: Tue, 12 Jul 2005 15:49:10 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0507121546160.17536@g5.osdl.org> (raw)
In-Reply-To: <20050712194220.GA28973@locomotive.unixthugs.org>
On Tue, 12 Jul 2005, Jeff Mahoney wrote:
>
> This patch contains the result of running scripts/Lindent against
> fs/reiserfs/*.c and include/linux/reiserfs_*.h.
That can't be true. It isn't actually following the Lindent rules. It has
that braindamaged "put the type on a separate line" thing for function
declarations, making a "grep" not show the type. That's very much against
the Linux coding style.
So either your "indent" is broken, or you've used something else than
Lindent.
Also, if it's a pure indentation change with no other changes, I'd almost
prefer it as a script, not a patch. That way it's obvious to everybody
that it's just doing indentation.
Linus
next prev parent reply other threads:[~2005-07-12 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 19:42 Jeff Mahoney
2005-07-12 21:46 ` Alexey Dobriyan
2005-07-12 22:49 ` Linus Torvalds [this message]
2005-07-12 23:16 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0507121546160.17536@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®