mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Bodo Eggert <7eggert@gmx.de>,
	perex@suse.cz, akpm@osdl.org, torvalds@osdl.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA
Date: Sun, 24 Jul 2005 11:39:52 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0507241112150.5658@be1.lrz> (raw)
In-Reply-To: <20050723164801.GE3160@stusta.de>

On Sat, 23 Jul 2005, Adrian Bunk wrote:
> On Tue, Jul 19, 2005 at 10:50:53PM +0200, Bodo Eggert wrote:

> > OTOH, the build system
> > should automatically propagate the dependencies. I asume that should be
> > easy, except for having the time to implement that.
> >...
> 
> There are nontrivial problems:
> E.g. what should happen if you select option A that depends on (B || C)?

You should in effect depend on ($original_depends) && (B || C). You'll 
just need to append all (recursive) dependencies in the selecting option.


last_length:=-1; /* impossible value */
while |options_with_unresolved_selects| > 0 do begin
	if |options_with_unresolved_selects| == last_length
	then goto circular_recursion_detected;
	last_length:=|options_with_unresolved_selects|;

	for i in options_with_unresolved_selects do begin
		for s in i->unresolved_selects do
			if 0 == |s->unresolved_selects|
			then begin
				add(i->depends, s->depends)
				delete_from(i->unresolved_selects, s)
			end
		if 0 == |i->unresolved_selects|
		then delete_from(options_with_unresolved_selects, i);
	end
end

> There's one opinion that options should be either select'able _or_ user 
> visible.

That would only result in ugly workarounds. Think about the kernel 
libraries. You'll want to manually select them, and you'll want to 
automatically select them, and you want both to be visible.

-- 
Funny quotes:
22. When everything's going your way, you're in the wrong lane and and going
    the wrong way.

      reply	other threads:[~2005-07-24  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-17 15:07 [PATCH] use select in sound/isa/Kconfig Bodo Eggert
2005-07-19 16:36 ` [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA Adrian Bunk
2005-07-19 20:50   ` Bodo Eggert
2005-07-23 16:48     ` Adrian Bunk
2005-07-24  9:39       ` Bodo Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0507241112150.5658@be1.lrz \
    --to=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®