From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262069AbVHAExe (ORCPT ); Mon, 1 Aug 2005 00:53:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262161AbVHAExe (ORCPT ); Mon, 1 Aug 2005 00:53:34 -0400 Received: from smtp.osdl.org ([65.172.181.4]:22697 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S262069AbVHAExd (ORCPT ); Mon, 1 Aug 2005 00:53:33 -0400 Date: Sun, 31 Jul 2005 21:53:18 -0700 (PDT) From: Linus Torvalds To: ambx1@neo.rr.com cc: Dave Airlie , Pavel Machek , Hugh Dickins , Andrew Morton , Dominik Brodowski , Daniel Ritz , Linux Kernel Mailing List , Len Brown Subject: Re: revert yenta free_irq on suspend In-Reply-To: <2e55d42e7427.2e74272e55d4@columbus.rr.com> Message-ID: References: <2e55d42e7427.2e74272e55d4@columbus.rr.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 31 Jul 2005 ambx1@neo.rr.com wrote: > > We either need to change every driver to free irqs or "harden" each > of them. No. No "either". Drivers need to be safe from the hw going away, whether it be physically or because it got shut down. > Freeing irqs obviously seems easier. No. Freeing irq's DOES NOT HELP. Listen to me. You need the hardening of the driver anyway for the hotplug case. Freeing irq's doesn't do anything for it, it's just shuffling the real problem under the carpet. So fix the damn problem _right_, and suddenly freeing the irq doesn't make any difference at all. It's just unnecessary and incorrect complexity. Linus