From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261216AbVHAU1I (ORCPT ); Mon, 1 Aug 2005 16:27:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261221AbVHAU1I (ORCPT ); Mon, 1 Aug 2005 16:27:08 -0400 Received: from smtp.osdl.org ([65.172.181.4]:57250 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261216AbVHAU1G (ORCPT ); Mon, 1 Aug 2005 16:27:06 -0400 Date: Mon, 1 Aug 2005 13:26:19 -0700 (PDT) From: Linus Torvalds To: Andrew Morton cc: Hugh Dickins , nickpiggin@yahoo.com.au, holt@sgi.com, mingo@elte.hu, roland@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug In-Reply-To: <20050801131240.4e8b1873.akpm@osdl.org> Message-ID: References: <20050801032258.A465C180EC0@magilla.sf.frob.com> <42EDDB82.1040900@yahoo.com.au> <20050801131240.4e8b1873.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Aug 2005, Andrew Morton wrote: > > We could just do: > > static inline int handle_mm_fault(...) > { > int ret = __handle_mm_fault(...); > > if (unlikely(ret == VM_FAULT_RACE)) > ret = VM_FAULT_MINOR; The reason I really dislike this whole VM_FAULT_RACE thing is that there's literally just one user that cares, and that user is such a special case anyway that we're _much_ better off fixing it in that user instead. The dirty bit thing is truly trivial, and is a generic VM feature. The fact that s390 does strange things is immaterial: I bet that s390 can be fixed much more easily than the suggested VM_FAULT_RACE patch, and quite frankly, bringing it semantically closer to the rest of the architectures is a _good_ thing regardless. Linus