From: Linus Torvalds <torvalds@osdl.org>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [patch 2.6.13-rc6] Fix kmem read on 32-bit archs
Date: Sun, 14 Aug 2005 09:50:03 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0508140944570.3553@g5.osdl.org> (raw)
In-Reply-To: <200508141214_MC3-1-A731-BBE9@compuserve.com>
On Sun, 14 Aug 2005, Chuck Ebbert wrote:
>
> It's ugly but so is the existing code. And it won't fix 64-bit
> archs AFAICT. Tested on 2.6.11, patch offsets fixed up for 2.6.13-rc6.
Btw, if you really want to allow negative ("huge positive") loff_t, then
you should do it the way we did "file->f_maxcount", and just have a u64
"file->f_maxpos" that we initialize to LONG_LONG_MAX or something like
that by default.
Then, the kmem_open() routine could set it to ULONG_LONG_MAX, and the
rw_verify_area check would change from comparing pos for being negative to
an unsigned compare of pos against "f_maxpos".
(That would also allow filesystems to limit the position to 32-bit values
if they wanted to, and felt that they didn't want to even handle anything
else).
Linus
next prev parent reply other threads:[~2005-08-14 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-14 16:12 Chuck Ebbert
2005-08-14 16:22 ` Andi Kleen
2005-08-14 16:24 ` Linus Torvalds
2005-08-14 16:50 ` Linus Torvalds [this message]
2005-08-14 20:36 Chuck Ebbert
2005-08-15 1:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0508140944570.3553@g5.osdl.org \
--to=torvalds@osdl.org \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®