From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Lee Revell <rlrevell@joe-job.com>,
Mark Knecht <markknecht@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
rmk@arm.linux.org.uk, Linus Torvalds <torvalds@osdl.org>,
Andrew Morton <akpm@osdl.org>,
andmike@us.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
Date: Wed, 19 Oct 2005 08:22:13 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0510190811380.20634@localhost.localdomain> (raw)
In-Reply-To: <20051019115435.GA31007@infradead.org>
Once again here's the patch.
Andrew, can you pull my previous one in favor of this one
I'm one of the rare breeds of programmers that over document, at least I
didn't comment "x equals a plus b" for "x = a + b" but I'm sure Christoph
would say that I was pretty close ;-)
Description:
Found in the -rt patch set. The scsi_error thread likely will be in the
TASK_INTERRUPTIBLE state upon exit. This patch fixes this bug.
Ingo,
I take it that you don't care about the comment for RT.
-- Steve
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6.14-rc4/drivers/scsi/scsi_error.c
===================================================================
--- linux-2.6.14-rc4.orig/drivers/scsi/scsi_error.c 2005-10-19 03:37:55.000000000 -0400
+++ linux-2.6.14-rc4/drivers/scsi/scsi_error.c 2005-10-19 08:10:23.000000000 -0400
@@ -1645,6 +1645,8 @@
set_current_state(TASK_INTERRUPTIBLE);
}
+ __set_current_state(TASK_RUNNING);
+
SCSI_LOG_ERROR_RECOVERY(1, printk("Error handler scsi_eh_%d"
" exiting\n",shost->host_no));
next prev parent reply other threads:[~2005-10-19 12:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-18 21:02 scsi_eh / 1394 bug - -rt7 Mark Knecht
2005-10-19 3:43 ` Lee Revell
2005-10-19 4:19 ` Lee Revell
2005-10-19 7:10 ` Steven Rostedt
2005-10-19 7:54 ` [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state Steven Rostedt
2005-10-19 11:31 ` Christoph Hellwig
2005-10-19 11:51 ` Steven Rostedt
2005-10-19 11:54 ` Christoph Hellwig
2005-10-19 12:22 ` Steven Rostedt [this message]
2005-10-19 11:56 ` Ingo Molnar
2005-10-19 11:59 ` Christoph Hellwig
2005-10-19 11:22 ` scsi_eh / 1394 bug - -rt7 Ingo Molnar
2005-10-19 15:23 ` Mark Knecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0510190811380.20634@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=akpm@osdl.org \
--cc=andmike@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markknecht@gmail.com \
--cc=mingo@elte.hu \
--cc=rlrevell@joe-job.com \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®