From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932380AbVKUQcb (ORCPT ); Mon, 21 Nov 2005 11:32:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932385AbVKUQcb (ORCPT ); Mon, 21 Nov 2005 11:32:31 -0500 Received: from mail-in-04.arcor-online.net ([151.189.21.44]:35494 "EHLO mail-in-04.arcor-online.net") by vger.kernel.org with ESMTP id S932380AbVKUQca convert rfc822-to-8bit (ORCPT ); Mon, 21 Nov 2005 11:32:30 -0500 Date: Mon, 21 Nov 2005 17:33:48 +0100 (CET) From: Bodo Eggert <7eggert@gmx.de> To: Con Kolivas cc: Daniel =?iso-8859-1?q?Marjam=E4ki?= , linux-kernel@vger.kernel.org, 7eggert@gmx.de, nish.aravamudan@gmail.com Subject: Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c) In-Reply-To: <200511211919.11429.kernel@kolivas.org> Message-ID: References: <5aZsv-3CJ-17@gated-at.bofh.it> <438180C0.2030503@comhem.se> <200511211919.11429.kernel@kolivas.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-be10.7eggert.dyndns.org-MailScanner-Information: See www.mailscanner.info for information X-be10.7eggert.dyndns.org-MailScanner: Found to be clean X-be10.7eggert.dyndns.org-MailScanner-From: 7eggert@web.de Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Nov 2005, Con Kolivas wrote: > On Mon, 21 Nov 2005 19:09, Daniel Marjamäki wrote: > > The way I do it: > > All systems will give me a delay for at least a few ms. > > I get the shortest timeout possible on each computer. > > Convention in the kernel would be > aztTimeOut = HZ / 100 ? : 1; > to be at least one tick (works for HZ even below 100) and is at least 10ms. You have to add one to the timeout, since you might be just before the end of the timeslice when the delay starts. aztTimeOut = (HZ / 100 ? : 1) + 1; -- Top 100 things you don't want the sysadmin to say: 11. Can you get VMS for this Sparc thingy?