From: Ingo Molnar <mingo@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: [patch] remove unnecessary asm/mutex.h from kernel/mutex-debug.c
Date: Tue, 10 Jan 2006 15:48:59 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.58.0601101546120.2133@devserv.devel.redhat.com> (raw)
In-Reply-To: <2758.1136902767@warthog.cambridge.redhat.com>
On Tue, 10 Jan 2006, David Howells wrote:
> I've found a compilation error in mutexes when using the null variety:
>
> In file included from kernel/mutex-debug.c:25:
> kernel/mutex-debug.h:23:1: warning: "__IP__" redefined
> In file included from include/asm/mutex.h:9,
> from kernel/mutex-debug.c:23:
> include/asm-generic/mutex-null.h:15:1: warning: this is the location of the previous definition
ok, the patch below should solve this. This didnt trigger on any of the
existing arches until now, because neither used asm-generic/null.h as
their method. I build-tested the patch. Linus, please apply.
Ingo
--
remove unnecessary (and incorrect) inclusion of asm/mutex.h, pointed out
by David Howells.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
----
kernel/mutex-debug.c | 2 --
1 files changed, 2 deletions(-)
Index: linux/kernel/mutex-debug.c
===================================================================
--- linux.orig/kernel/mutex-debug.c
+++ linux/kernel/mutex-debug.c
@@ -20,8 +20,6 @@
#include <linux/kallsyms.h>
#include <linux/interrupt.h>
-#include <asm/mutex.h>
-
#include "mutex-debug.h"
/*
prev parent reply other threads:[~2006-01-10 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 14:19 Mutex compilation error David Howells
2006-01-10 20:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0601101546120.2133@devserv.devel.redhat.com \
--to=mingo@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®