mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vadim Lobanov <vlobanov@speakeasy.net>
To: Ulrich Drepper <drepper@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix poll() nfds check.
Date: Thu, 6 Jul 2006 09:28:05 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0607060923440.21972@shell3.speakeasy.net> (raw)
In-Reply-To: <a36005b50607060844s6c19fb3fp6e91eb1dc86dfbec@mail.gmail.com>

On Thu, 6 Jul 2006, Ulrich Drepper wrote:

> On 7/5/06, Andrew Morton <akpm@osdl.org> wrote:
> > [EINVAL]
> >     The nfds argument is greater than {OPEN_MAX}, or ...
>
> This requirement must be treated the same way as the EMFILE error in
> open(): ignore the OPEN_MAX limit if ulimit says so.  The question is
> what to do if the ulimit < OPEN_MAX.  POSIX does not require OPEN_MAX
> to be the exact limit.

This interpretation makes more sense to me. No hardcoded magic number
limits where the behavior of the syscall changes.

> So, I think removing the OPEN_MAX comparison is the correct way to do
> this here.  If somebody wants strict POSIX compliance they have to set
> ulimit -n to 256.

Andrew, assuming that you're willing to make this change to the code, I
can redo this patch against the latest rc and resend, if that'll make it
easier to apply.

-- Vadim Lobanov

  reply	other threads:[~2006-07-06 16:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06  3:00 Vadim Lobanov
2006-07-06  3:39 ` Andrew Morton
2006-07-06  4:02   ` Vadim Lobanov
2006-07-06 15:44   ` Ulrich Drepper
2006-07-06 16:28     ` Vadim Lobanov [this message]
2006-07-07  3:00 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0607060923440.21972@shell3.speakeasy.net \
    --to=vlobanov@speakeasy.net \
    --cc=akpm@osdl.org \
    --cc=drepper@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®