From: Trent Piepho <xyzzy@speakeasy.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-dvb-maintainer@linuxtv.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
video4linux-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] Re: [GIT PATCHES] V4L/DVB updates
Date: Mon, 16 Apr 2007 14:49:51 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0704161443050.16569@shell2.speakeasy.net> (raw)
In-Reply-To: <d120d5000704160850m7c08debam9b0869cbb19cc593@mail.gmail.com>
On Mon, 16 Apr 2007, Dmitry Torokhov wrote:
> Hi Mauro,
>
> On 4/15/07, Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> > - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci
>
> While move of spin_lock_init before request_irq is obviously correct I
> wonder what is the reason behind changing spin_lock_irq() into
> spin_lock_irqsave() as I do not see flexcop_pci_isr being called from
> anywhere but IRQ context.
>
> BTW, is irq_lock needed at all?
There was some more discussion on the linux-dvb list
http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017024.html , and I
think we came to the conclusion that irq_lock isn't needed at all. It does
nothing but serialize the ISR and ISRs are automatically serialized by the
kernel.
prev parent reply other threads:[~2007-04-16 21:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 15:31 Mauro Carvalho Chehab
2007-04-16 0:33 ` [v4l-dvb-maintainer] " Michael Krufky
2007-04-16 5:22 ` Manu Abraham
2007-04-16 8:17 ` Markus Rechberger
2007-04-16 10:00 ` Mauro Carvalho Chehab
2007-04-16 14:15 ` Adrian Bunk
2007-04-16 14:52 ` CIJOML
2007-04-16 15:00 ` CIJOML
2007-04-16 15:34 ` Michael Krufky
2007-04-16 16:16 ` Markus Rechberger
2007-04-27 21:34 ` Trent Piepho
2007-04-27 22:43 ` Markus Rechberger
2007-04-28 6:33 ` Trent Piepho
2007-04-28 9:47 ` Markus Rechberger
2007-04-16 16:18 ` CIJOML
2007-04-16 16:25 ` Michael Krufky
2007-04-16 22:15 ` hermann pitton
2007-04-17 3:42 ` Mauro Carvalho Chehab
2007-04-16 15:50 ` Dmitry Torokhov
2007-04-16 21:49 ` Trent Piepho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0704161443050.16569@shell2.speakeasy.net \
--to=xyzzy@speakeasy.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®