mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trent Piepho <xyzzy@speakeasy.org>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux DVB <linux-dvb@linuxtv.org>
Subject: Re: [linux-dvb] [PATCH] dvb-core: Handle failures to create devices
Date: Tue, 1 May 2007 14:21:19 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0705011418130.309@shell2.speakeasy.net> (raw)
In-Reply-To: <463774FE.9030104@simon.arlott.org.uk>

On Tue, 1 May 2007, Simon Arlott wrote:
> dvb-core is not started early enough when device drivers that use dvb are
> compiled in so device_register_device fails (silently) since dvb_class is
> NULL, this runs dvb_init using subsys_initclass instead of module_init.
>
> dvb_register_device will now check the return value of class_device_create.

Good catch.

> +		printk("%s: failed to create device dvb%d.%s%d (%ld)\n", __FUNCTION__,
> +			adap->num, dnames[type], id, PTR_ERR(clsdev));
> +		return PTR_ERR(clsdev);

printk(KERN_ERR "...."


  parent reply	other threads:[~2007-05-01 21:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01 17:12 Simon Arlott
2007-05-01 17:14 ` Simon Arlott
2007-05-01 21:21 ` Trent Piepho [this message]
2007-05-01 21:33   ` [linux-dvb] " Simon Arlott
2007-05-06 22:50     ` Trent Piepho
2007-05-06 22:58       ` Simon Arlott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0705011418130.309@shell2.speakeasy.net \
    --to=xyzzy@speakeasy.org \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®