From: Bodo Eggert <7eggert@gmx.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: kai@germaschewski.name, Tony Breeds <tony@bakeyournoodle.com>
Subject: [PATCH] mkmakefile: include ARCH on O= builds
Date: Fri, 13 Jul 2007 20:16:34 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.58.0707132012220.3037@be1.lrz> (raw)
If you build using O=builddir ARCH=bar, you'll currently need to supply
ARCH= on builds from the builddir, too. With this patch, the generated
Makefile will do that instead.
make ARCH= will still override the Makefile default, allowing existing
scripts to work correctly.
Signed-Off-By: Bodo Eggert <7eggert@gmx.de>
---
Changed from previous submission: Documentation is now as intended
diff -X dontdiff -pruN linux-2.6.22/Makefile linux-2.6.22.changed/Makefile
--- linux-2.6.22/Makefile 2007-07-11 23:15:33.000000000 +0200
+++ linux-2.6.22.changed/Makefile 2007-07-12 02:59:39.000000000 +0200
@@ -357,7 +357,7 @@ PHONY += outputmakefile
outputmakefile:
ifneq ($(KBUILD_SRC),)
$(Q)$(CONFIG_SHELL) $(srctree)/scripts/mkmakefile \
- $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL)
+ $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL) $(ARCH)
endif
# To make sure we do not include .config for any of the *config targets
diff -X dontdiff -pruN linux-2.6.22/scripts/mkmakefile linux-2.6.22.changed/scripts/mkmakefile
--- linux-2.6.22/scripts/mkmakefile 2006-11-29 22:57:37.000000000 +0100
+++ linux-2.6.22.changed/scripts/mkmakefile 2007-07-12 03:03:49.000000000 +0200
@@ -8,6 +8,7 @@
# $2 - Output directory
# $3 - version
# $4 - patchlevel
+# $5 - arch
test ! -r $2/Makefile -o -O $2/Makefile || exit 0
@@ -21,16 +22,17 @@ PATCHLEVEL = $4
KERNELSRC := $1
KERNELOUTPUT := $2
+ARCH := $5
MAKEFLAGS += --no-print-directory
.PHONY: all \$(MAKECMDGOALS)
all:
- \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT)
+ \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT) ARCH=\$(ARCH)
Makefile:;
\$(filter-out all Makefile,\$(MAKECMDGOALS)) %/:
- \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT) \$@
+ \$(MAKE) -C \$(KERNELSRC) O=\$(KERNELOUTPUT) ARCH=\$(ARCH) \$@
EOF
--
The tough part about being an officer is that the troops don't know what
they want, but they know for certain what they DON'T want.
next reply other threads:[~2007-07-13 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 18:16 Bodo Eggert [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-12 1:40 Bodo Eggert
2007-07-12 1:58 ` Tony Breeds
2007-07-12 2:00 ` Randy Dunlap
2007-07-12 15:09 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0707132012220.3037@be1.lrz \
--to=7eggert@gmx.de \
--cc=kai@germaschewski.name \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®