mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trent Piepho <xyzzy@speakeasy.org>
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	acpi4asus-u@pimp.vs19.net, Gabriel C <nix.or.die@googlemail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Corentin Chary <corentincj@iksaif.net>
Subject: Re: [1/2] 2.6.23-rc1: known regressions
Date: Mon, 23 Jul 2007 04:17:05 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.58.0707230404290.5535@shell2.speakeasy.net> (raw)
In-Reply-To: <46A47932.8000709@googlemail.com>

On Mon, 23 Jul 2007, Michal Piotrowski wrote:
> ACPI
>
> Subject         : drivers/misc/asus-laptop.c:*: error: 'struct led_classdev' has no member named 'class_dev'
> References      : http://lkml.org/lkml/2007/7/22/299
> Last known good : ?
> Submitter       : Gabriel C <nix.or.die@googlemail.com>
> Caused-By       : ?
> Handled-By      : ?
> Status          : unknown

Here's a trivial patch for this one.
------------------------------------------------------------------------
asus-laptop: Sync with changes to led class

Driver was broken by commit f8a7c6fe14f556ca8eeddce258cb21392d0c3a2f
	leds: Convert from struct class_device to struct device

	Convert the LEDs class from struct class_device to struct device
	since class_device is scheduled for removal.

Use (struct led_classdev).dev instead of (struct led_classdev).class_dev

diff -r 3f21143ca44c drivers/misc/asus-laptop.c
--- a/drivers/misc/asus-laptop.c	Sun Jul 22 21:30:24 2007 +0000
+++ b/drivers/misc/asus-laptop.c	Mon Jul 23 03:47:55 2007 -0700
@@ -1067,8 +1067,8 @@ static void asus_backlight_exit(void)
 }

 #define  ASUS_LED_UNREGISTER(object)				\
-	if(object##_led.class_dev				\
-	   && !IS_ERR(object##_led.class_dev))			\
+	if(object##_led.dev					\
+	   && !IS_ERR(object##_led.dev))			\
 		led_classdev_unregister(&object##_led)

 static void asus_led_exit(void)

  parent reply	other threads:[~2007-07-23 11:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-23  9:47 Michal Piotrowski
2007-07-23 10:21 ` Al Viro
2007-07-23 11:17 ` Trent Piepho [this message]
2007-07-23 11:25   ` Al Viro
2007-07-23 13:12     ` Richard Purdie
2007-07-23 13:36       ` Al Viro
2007-07-23 14:32         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0707230404290.5535@shell2.speakeasy.net \
    --to=xyzzy@speakeasy.org \
    --cc=acpi4asus-u@pimp.vs19.net \
    --cc=corentincj@iksaif.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=nix.or.die@googlemail.com \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®