From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935499AbXG3L3G (ORCPT ); Mon, 30 Jul 2007 07:29:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759496AbXG3L2x (ORCPT ); Mon, 30 Jul 2007 07:28:53 -0400 Received: from ms-smtp-04.nyroc.rr.com ([24.24.2.58]:49651 "EHLO ms-smtp-04.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759075AbXG3L2w (ORCPT ); Mon, 30 Jul 2007 07:28:52 -0400 Date: Mon, 30 Jul 2007 07:28:42 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: Daniel Walker , linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH -rt 2/9] Dont allow non-threaded softirqs and threaded hardirqs In-Reply-To: <20070730092331.GB25640@elte.hu> Message-ID: References: <20070730024534.369897977@mvista.com> <20070730024718.890110769@mvista.com> <20070730092331.GB25640@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org -- On Mon, 30 Jul 2007, Ingo Molnar wrote: > > From: Steven Rostedt > > > > I think this was sent before, and it did cause problems before. Would > > there be *any* reason to have non-threaded softirqs but threaded > > hardirqs. I can see lots of issues with that. > > please elaborate in precise terms: what issues can you see? > Hi Ingo, I don't remember the exact details, I can try to find the thread. But I remember someone was having their system lock up strangly. We later found that they had softirqs as normal softirqs and interrupts as threads. I think there was some driver that didn't expect the softirq to preempt the irq handler. Perhaps the softirq was using spin_lock_irq while the irq thread was just using spin_lock, which I can see as being something normal. The standard Linux does not expect an interrupt to be preempted by a softirq, and with interrupts as threads but not softirqs, I can see that happening a lot. -- Steve