From: Steven Rostedt <rostedt@goodmis.org>
To: Gregory Haskins <ghaskins@novell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch 2/8] track highest prio queued on runqueue
Date: Fri, 19 Oct 2007 15:57:45 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0710191553480.4602@gandalf.stny.rr.com> (raw)
In-Reply-To: <1192823151.9564.30.camel@ghaskins-t60p.haskins.net>
--
On Fri, 19 Oct 2007, Gregory Haskins wrote:
> >
> > struct task_struct *migration_thread;
> > struct list_head migration_queue;
> > @@ -972,6 +974,8 @@ static void activate_task(struct rq *rq,
> >
> > enqueue_task(rq, p, wakeup);
> > inc_nr_running(p, rq);
> > +
> > + rq_prio_add_task(rq, p);
> > }
>
> We are better off doing this in enqueue_task() or PI boosting will fail
> to alter the prio of the RQ.
I thought about that too, but thought it was also too -rt base. But I
think I'll move it regardless.
>
> >
> > /*
> > @@ -984,6 +988,8 @@ static void deactivate_task(struct rq *r
> >
> > dequeue_task(rq, p, sleep);
> > dec_nr_running(p, rq);
> > +
> > + rq_prio_remove_task(rq, p);
>
> Ditto for dequeue_task()
Will move.
>
> > }
> >
> > /**
> > @@ -6619,6 +6625,7 @@ void __init sched_init(void)
> > rq->cpu = i;
> > rq->migration_thread = NULL;
> > INIT_LIST_HEAD(&rq->migration_queue);
> > + rq->highest_prio = MAX_RT_PRIO;
> > #endif
> > atomic_set(&rq->nr_iowait, 0);
> >
> > Index: linux-test.git/kernel/sched_rt.c
> > ===================================================================
> > --- linux-test.git.orig/kernel/sched_rt.c 2007-10-19 12:33:09.000000000 -0400
> > +++ linux-test.git/kernel/sched_rt.c 2007-10-19 12:33:23.000000000 -0400
> > @@ -110,6 +110,31 @@ static struct task_struct *pick_next_tas
> > return next;
> > }
> >
> > +#ifdef CONFIG_SMP
> > +static inline void rq_prio_add_task(struct rq *rq, struct task_struct *p)
> > +{
> > + if (unlikely(rt_task(p)) && p->prio < rq->highest_prio)
> > + rq->highest_prio = p->prio;
> > +}
> > +
> > +static inline void rq_prio_remove_task(struct rq *rq, struct task_struct *p)
> > +{
> > + struct rt_prio_array *array;
> > +
> > + if (unlikely(rt_task(p))) {
> > + if (rq->rt_nr_running) {
> > + if (p->prio >= rq->highest_prio) {
>
> <= ?
>
> We only need to recalc if the task being removed was the highest prio
> (or higher, if that were possible but it shouldnt be).
That's what I meant to do. (/me had another confusion between > and < for
the lower the prio the higher the priority!!!!).
>
> I think this logic will technically work as-is because every task is
That wasn't planned. I wanted to only recalc if the priority was >= the
the rq priority, which would have been. p->prio <= rq->highest_prio.
Yes, I thought to myself (that should never be higher!) but I was
paranoid. So the test is not what I meant.
> always >= highest in a properly accounted system, so you will just
> simply recalc for every remove. But I do like the optimization that you
> were trying to add.
>
> So for the paranoid:
>
> BUG_ON(p->prio < rq->highest_prio);
> if (p->prio == rq->highest_prio) {
> /* recalc */
> }
I'll add that with a switch to WARN_ON.
-- Steve
next prev parent reply other threads:[~2007-10-19 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 18:42 [patch 0/8] New RT Task Balancing Steven Rostedt
2007-10-19 18:42 ` [patch 1/8] Add rt_nr_running accounting Steven Rostedt
2007-10-20 16:45 ` Dmitry Adamushko
2007-10-21 2:13 ` Steven Rostedt
2007-10-19 18:42 ` [patch 2/8] track highest prio queued on runqueue Steven Rostedt
2007-10-19 19:19 ` Steven Rostedt
2007-10-19 19:45 ` Gregory Haskins
2007-10-19 19:57 ` Steven Rostedt [this message]
2007-10-20 18:14 ` Dmitry Adamushko
2007-10-21 2:19 ` Steven Rostedt
2007-10-19 18:42 ` [patch 3/8] push RT tasks Steven Rostedt
2007-10-19 18:42 ` [patch 4/8] RT overloaded runqueues accounting Steven Rostedt
2007-10-19 18:42 ` [patch 5/8] Move prototypes together Steven Rostedt
2007-10-19 18:43 ` [patch 6/8] pull RT tasks Steven Rostedt
2007-10-19 19:24 ` Peter Zijlstra
2007-10-19 19:35 ` Peter Zijlstra
2007-10-19 19:43 ` Steven Rostedt
2007-10-21 9:35 ` Dmitry Adamushko
2007-10-22 13:55 ` Steven Rostedt
2007-10-21 11:59 ` Dmitry Adamushko
2007-10-22 14:05 ` Steven Rostedt
2007-10-22 22:34 ` Dmitry Adamushko
2007-10-23 1:16 ` Steven Rostedt
2007-10-19 18:43 ` [patch 7/8] wake up balance RT Steven Rostedt
2007-10-19 18:43 ` [patch 8/8] disable CFS RT load balancing Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0710191553480.4602@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®