Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB fixes

[Trent Piepho <xyzzy@speakeasy.org>]

On Wed, 13 Feb 2008, Ricardo Cerqueira wrote:
> On Wed, 2008-02-13 at 10:45 -0800, Trent Piepho wrote:
> > On Wed, 13 Feb 2008, Mauro Carvalho Chehab wrote:
> > > On Tue, 12 Feb 2008 21:21:43 -0800 (PST)
> > > Trent Piepho <xyzzy@speakeasy.org> wrote:
> > >
> > Nobody points to any issues, ever, when this happens.  Look at how broken
> > the v4l2 only bttv driver was.  You still can't unload and load cx88-dvb
> > since Markus's patch for hotplug, no one's fixed that regression.  Now
> > there's yet another race in the cx88 subdriver code.  Maybe the original
> > author who added that code should feel some motiviation to fix the
> > regressions it caused....
>
> Read the code that was actually committed: here's a helpful link:
>
> http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=41a93616082af630e7242cba766a161d7847560b

I did.  Looks like there is a race on access to core->active_ref.

> > I don't have the time or the desire to be the janitor who cleans up after
> > sloppy coders' bugs.
>
> You properly raised a red flag, and got a fix in return.
> Don't expect fixes to be accompanied by a "are you happy now?"
> follow-up; if you took the time to check the first commit, take the time
> to read the rest.

You could also CC the relevant parties.  Unless you're hoping they won't
notice something.