From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbYDIXvY (ORCPT ); Wed, 9 Apr 2008 19:51:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752714AbYDIXvO (ORCPT ); Wed, 9 Apr 2008 19:51:14 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:39236 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbYDIXvO (ORCPT ); Wed, 9 Apr 2008 19:51:14 -0400 Date: Wed, 9 Apr 2008 19:51:12 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: LKML cc: Ingo Molnar , Peter Zijlstra , Linus Torvalds , akpm@osdl.org, Rusty Russell , Glauber de Oliveira Costa , Jan Beulich , Andi Kleen , Thomas Gleixner , pinskia@gcc.gnu.org Subject: Re: [PATCH] pop previous section in alternative.c In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Apr 2008, Steven Rostedt wrote: > > gcc expects all toplevel assembly to return to the original section type. > The code in alteranative.c does not do this. This caused some strange bugs > in sched-devel where code would end up in the .rodata section and when > the kernel sets the NX bit on all .rodata, the kernel would crash when > executing this code. > > This patch adds a .previous marker to return the code back to the > original section. > Oh, and this would not be complete without giving Andrew Pinski complete credit for telling me it wasn't a gcc bug but a bug in the toplevel asm code in the kernel. ;-) -- Steve