From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756643AbYDWMy3 (ORCPT ); Wed, 23 Apr 2008 08:54:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752814AbYDWMyU (ORCPT ); Wed, 23 Apr 2008 08:54:20 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:37280 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbYDWMyS (ORCPT ); Wed, 23 Apr 2008 08:54:18 -0400 Date: Wed, 23 Apr 2008 08:54:17 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Gregory Haskins cc: Ingo Molnar , Dmitry Adamushko , linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH 1/2] sched: fix RT task-wakeup logic In-Reply-To: <20080423111329.4981.88455.stgit@novell1.haskins.net> Message-ID: References: <20080423111313.4981.37345.stgit@novell1.haskins.net> <20080423111329.4981.88455.stgit@novell1.haskins.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Apr 2008, Gregory Haskins wrote: > Dmitry Adamushko pointed out a logic error in task_wake_up_rt() where we > will always evaluate to "true". You can find the thread here: > > http://lkml.org/lkml/2008/4/22/296 > > In reality, we only want to try to push tasks away when a wake up request is > not going to preempt the current task. So lets fix it. > > Note: We introduce test_tsk_need_resched() instead of open-coding the flag > check so that the merge-conflict with -rt should help remind us that we > may need to support NEEDS_RESCHED_DELAYED in the future, too. > > Signed-off-by: Gregory Haskins > CC: Dmitry Adamushko > CC: Ingo Molnar > CC: Steven Rostedt Acked-by: Steven Rostedt -- Steve