From: Trent Piepho <xyzzy@speakeasy.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [i2c] [PATCH 1/1] i2c: align i2c_device_id
Date: Mon, 19 May 2008 21:25:01 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0805192105470.6129@shell4.speakeasy.net> (raw)
In-Reply-To: <4831D2F3.6020506@gmail.com>
On Mon, 19 May 2008, Jiri Slaby wrote:
> On 05/19/2008 09:00 PM, Jean Delvare wrote:
> > Thanks for this patch, it's in my i2c tree now and will be sent to
> > Linus by the end of the week. I wasn't aware of this possible alignment
> > issue, sorry.
>
> To be honest, neither I was until I hit it while testing hid bus (where I did
> the same mistake). Thanks.
Is there any more information about this? Items in a structure should be
aligned to the alignment required by their type. Usually sizeof(x) ==
alignof(x), but not always.
I guess in this case the structures are used as a cross-platform binary on
disk representation, and so the alignment of the build host must match the
alignment of the target?
Maybe it would be better to include the alignment attribute in the
definition of kernel_ulong_t?
prev parent reply other threads:[~2008-05-20 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 13:18 Jiri Slaby
2008-05-19 13:40 ` Sam Ravnborg
2008-05-19 19:00 ` Jean Delvare
2008-05-19 19:20 ` Jiri Slaby
2008-05-20 4:25 ` Trent Piepho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0805192105470.6129@shell4.speakeasy.net \
--to=xyzzy@speakeasy.org \
--cc=i2c@lm-sensors.org \
--cc=jirislaby@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®