From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757958AbYGDB4R (ORCPT ); Thu, 3 Jul 2008 21:56:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753491AbYGDB4F (ORCPT ); Thu, 3 Jul 2008 21:56:05 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:60287 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459AbYGDB4E (ORCPT ); Thu, 3 Jul 2008 21:56:04 -0400 Date: Thu, 3 Jul 2008 21:56:00 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Andrew Morton cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, akpm@linuxfoundation.org, peterz@infradead.org, stable@kernel.org Subject: Re: [PATCH] hrtimer: prevent migration for raising softirq In-Reply-To: <20080703155302.5f86d8f4.akpm@linux-foundation.org> Message-ID: References: <20080703155302.5f86d8f4.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Jul 2008, Andrew Morton wrote: > > On Thu, 3 Jul 2008 14:31:26 -0400 (EDT) > Steven Rostedt wrote: > > > Due to a possible deadlock, the waking of the softirq was pushed outside > > of the hrtimer base locks. See commit 0c96c5979a522c3323c30a078a70120e29b5bdbc > > Please quote at least the patch title rather than raw hashes. Sorry, will do next time. I'm getting to use to git. > > afaict that patch isn't in 2.6.25 yet you copied stable@kernel.org. > Please clarify. The reason I did so is because that commit has a Cc: stable@kernel.org. I figured that if that patch is in queue for stable this one should be in right afterwards. > > > > > Unfortunately this allows the task to migrate after setting up the softirq > > and raising it. Since softirqs run a queue that is per-cpu we may raise the > > softirq on the wrong CPU and this will keep the queued softirq task from > > running. > > > > To solve this issue, this patch disables preemption around the releasing > > of the hrtimer lock and raising of the softirq. > > > > This seems to be 2.6.26 material and is inapplicable to 2.6.25? > [/me goes to look at the 2.6.25.4 he has sitting around] The above mentioned commit (Title: hrtimer: raise softirq unlocked to avoid circular lock dependency) is, in fact, in 2.6.25.4. -- Steve