From: Trent Piepho <xyzzy@speakeasy.org>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Jean-Francois Moine <moinejf@free.fr>,
David Ellingsworth <david@identd.dyndns.org>,
linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gspca: add missing .type field check in VIDIOC_G_PARM
Date: Thu, 19 Mar 2009 17:47:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0903191741540.28292@shell2.speakeasy.net> (raw)
In-Reply-To: <49C2C3C8.3000300@freemail.hu>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/PLAIN; charset=X-UNKNOWN, Size: 590 bytes --]
On Thu, 19 Mar 2009, [UTF-8] Németh Márton wrote:
> The gspca webcam driver does not check the .type field of struct v4l2_streamparm.
> This field is an input parameter for the driver according to V4L2 API specification,
> revision 0.24 [1]. Add the missing check.
I think this check could go in the v4l2 core too. It already does a
similar check for QUERYBUF, QBUF, DQBUF, etc. If the driver doesn't
provide a method for ->vidioc_try_fmt_foo() then the v4l2 core will reject
a call with .type == V4L2_BUF_TYPE_foo.
It seems like it should be ok to do this for S_PARM and G_PARM too.
next prev parent reply other threads:[~2009-03-20 0:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 17:48 Németh Márton
2009-03-18 21:45 ` David Ellingsworth
2009-03-19 5:50 ` Németh Márton
2009-03-19 6:52 ` Németh Márton
2009-03-19 7:34 ` Trent Piepho
2009-03-19 22:14 ` Németh Márton
2009-03-20 0:47 ` Trent Piepho [this message]
2009-03-27 10:42 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0903191741540.28292@shell2.speakeasy.net \
--to=xyzzy@speakeasy.org \
--cc=david@identd.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®