From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758304AbZC0Tpy (ORCPT ); Fri, 27 Mar 2009 15:45:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753456AbZC0Tpp (ORCPT ); Fri, 27 Mar 2009 15:45:45 -0400 Received: from mail12.sea5.speakeasy.net ([69.17.117.14]:52510 "EHLO mail12.sea5.speakeasy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbZC0Tpo convert rfc822-to-8bit (ORCPT ); Fri, 27 Mar 2009 15:45:44 -0400 Date: Fri, 27 Mar 2009 12:45:40 -0700 (PDT) From: Trent Piepho X-X-Sender: xyzzy@shell2.speakeasy.net To: Mauro Carvalho Chehab cc: =?ISO-8859-1?B?TultZXRoIE3hcnRvbg==?= , linux-media@vger.kernel.org, LKML Subject: Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also In-Reply-To: <20090327131729.0842bdec@pedra.chehab.org> Message-ID: References: <49CA611B.5050902@freemail.hu> <20090327131729.0842bdec@pedra.chehab.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: > On Wed, 25 Mar 2009 17:51:39 +0100 > Németh Márton wrote: > > > From: Márton Németh > > > > When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus driver > > does not fill the reserved fields of the struct v4l2_audio with zeros as > > required by V4L2 API revision 0.24 [1]. Add the missing initializations to > > the V4L2 framework. > > > > The patch was tested with v4l-test 0.10 [2] with gspca_sunplus driver and > > with Trust 610 LCD POWERC@M ZOOM webcam. > > It didn't apply against the development tree. Anyway, a recent patch removed > the need of memset there. the memory fill with zero now happens at the same > code we copy the structure values. That code is in video_ioctl2, which gspca doesn't use.