mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Anastasov <ja@ssi.bg>
To: xiaoyu Du <tingsrain@gmail.com>
Cc: Simon Horman <horms@verge.net.au>,
	David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [patch nf-next] IPVS: ICMPv6 checksum calculation
Date: Fri, 20 Aug 2010 16:48:20 +0300 (EEST)	[thread overview]
Message-ID: <Pine.LNX.4.58.1008201643260.4539@u.domain.uli> (raw)
In-Reply-To: <AANLkTi=tVieTnz1R=9Jh45LweUwJ=mtszM1U9XAEVrK7@mail.gmail.com>


	Hello,

On Fri, 20 Aug 2010, xiaoyu Du wrote:

> I just replied to thank for his idea then, as he gived me some ideas
> on how to manipulate
> checksum. I tested the code today, but it doesn't seem to work. (I just wrote a
> netfilter module and hooked the code on local_out , then ping6 the
> address on another PC,
> It failed.). I'll find out why.

	May be because I copied csum_ipv6_magic() code from
your patch. Please, try with one '~' before csum_ipv6_magic.

> >> >>>      icmph->icmp6_cksum = csum_ipv6_magic(&iph->saddr,
> >> >>>              &iph->daddr,
> >> >>>              skb->len - icmp_offset, IPPROTO_ICMPV6,
> >> >>>              0);
> >> >>>      skb->csum_start = skb_network_header(skb) - skb->head +
> >> >>>                        icmp_offset;
> >> >>>      skb->csum_offset = offsetof(struct icmp6hdr, icmp6_cksum);
> >> >>>      skb->ip_summed = CHECKSUM_PARTIAL;

Regards

--
Julian Anastasov <ja@ssi.bg>

  reply	other threads:[~2010-08-20 13:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  7:00 Simon Horman
2010-08-17  9:25 ` Julian Anastasov
2010-08-18  0:21   ` Simon Horman
2010-08-18  0:26     ` David Miller
2010-08-18  4:20       ` xiaoyu Du
2010-08-18  5:57         ` Simon Horman
2010-08-20 11:14           ` xiaoyu Du
2010-08-20 13:48             ` Julian Anastasov [this message]
2010-08-23  2:54               ` xiaoyu Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.1008201643260.4539@u.domain.uli \
    --to=ja@ssi.bg \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tingsrain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®