From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Hunold <hunold@convergence.de>
Subject: Re: [PATCH][2.4] change two annoying messages from framebuffer drivers
Date: Thu, 18 Dec 2003 17:05:06 -0200 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.58L.0312181704310.23845@logos.cnet> (raw)
In-Reply-To: <Pine.GSO.4.58.0312151109460.16964@waterleaf.sonytel.be>
On Mon, 15 Dec 2003, Geert Uytterhoeven wrote:
> On Fri, 12 Dec 2003, Michael Hunold wrote:
> > Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR
> > to say that their particular card has *not* been found which is very
> > annoying.
> >
> > Especially the clgenfb.c driver simply says on bootup:
> > > Couldn't find PCI device
> > which can really confuse newbie users.
> >
> > The appended patch replaces two KERN_ERR with KERN_INFO and additionally
> > makes the clgen.c message more descriptive.
> >
> > Please apply, thanks!
>
> Patch looks OK to me, except that I would print `clgenfb' instead of `clgen'.
That looks sane.
Can you change it Michael?
next prev parent reply other threads:[~2003-12-18 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-12 12:57 Michael Hunold
2003-12-15 10:10 ` Geert Uytterhoeven
2003-12-18 19:05 ` Marcelo Tosatti [this message]
2003-12-22 20:39 ` Michael Hunold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58L.0312181704310.23845@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=geert@linux-m68k.org \
--cc=hunold@convergence.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®