mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Daniel Tram Lux <daniel@starbattle.com>, steve@drifthost.com
Cc: Linus Torvalds <torvalds@osdl.org>,
	James Bourne <jbourne@hardrock.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Gergely Tamas <dice@mfa.kfki.hu>,
	Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: no DRQ after issuing WRITE was Re: 2.4.23-uv3 patch set released
Date: Tue, 30 Dec 2003 19:46:44 -0200 (BRST)	[thread overview]
Message-ID: <Pine.LNX.4.58L.0312301849400.23875@logos.cnet> (raw)
In-Reply-To: <Pine.LNX.4.58.0312301130430.2065@home.osdl.org>


Daniel, Steve,

Linus believes the reason for the "no DRQ after issuing WRITE" (and
further problems caused by it) is the too small timeout used in
ide_wait_stat().

Can you guys please change this line in include/linux/ide.h

#define WAIT_DRQ        (5*HZ/100)      /* 50msec - spec allows up to 20ms */

to

#define WAIT_DRQ	(5*HZ/50)

And check if that makes the problem go away?

On Tue, 30 Dec 2003, Linus Torvalds wrote:

> I suspect that anything in IDE that uses that idiotic "local_irq_set()"
> macro is just broken, and should be rewritten to explicitly enable
> interrupts. As it is, the code is just incredibly _strange_, and it
> actually enables interrupts at all the wrong places.
>
> Anyway, in ide_wait_stat(), the "timeout" value is always either
> "WAIT_DRQ" (5*HZ/100) or it is "WAIT_READY" (3*HZ/100). And look at
> WAIT_READY a bit more:
>
> 	#if defined(CONFIG_APM) || defined(CONFIG_APM_MODULE)
> 	#define WAIT_READY      (5*HZ)          /* 5sec - some laptops are very slow */
> 	#else
> 	#define WAIT_READY      (3*HZ/100)      /* 30msec - should be instantaneous */
> 	#endif /* CONFIG_APM || CONFIG_APM_MODULE */
>
> I bet that the _real_ problem is this. That "3*HZ/100" value is just too
> damn short. It has already been increased to 5*HZ for anything that has
> APM enabled, but anybody who doesn't use APM gets a _really_ short
> timeout.
>
> My suggestion: change the non-APM timeout to something much larger. Make
> it ten times bigger, rather than leaving it at a value that us so small
> that a single interrupt could make a difference..
>
> In fact, right now a single timer interrupt on 2.4.x is the difference
> between waiting 20ms and 30ms. That's a _big_ relative difference.

Small correction: people are not hitting the WAIT_READY (they are hitting
the problem from ide-disk.c, which uses WAIT_DRQ). But still...


  reply	other threads:[~2003-12-30 21:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-29  7:58 James Bourne
2003-12-30 11:36 ` Marcelo Tosatti
2003-12-30 19:59   ` Linus Torvalds
2003-12-30 21:46     ` Marcelo Tosatti [this message]
2003-12-30 21:57       ` no DRQ after issuing WRITE was " Linus Torvalds
2003-12-30 22:21         ` Marcelo Tosatti
2003-12-30 23:18           ` Eric D. Mudama
2003-12-30 22:23         ` Rob Love
2003-12-30 22:54           ` Linus Torvalds
2003-12-30 22:58             ` Rob Love
2004-01-03 11:22               ` Daniel Tram Lux
2004-01-03 18:57                 ` Linus Torvalds
2004-01-03 19:27                   ` Daniel Tram Lux
2004-01-03 22:10     ` Pavel Machek
2003-12-31  6:10   ` James Bourne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58L.0312301849400.23875@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=daniel@starbattle.com \
    --cc=dice@mfa.kfki.hu \
    --cc=jbourne@hardrock.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@drifthost.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®