mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Greg KH <greg@kroah.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PC300 update
Date: Wed, 28 Jan 2004 22:02:34 -0200 (BRST)	[thread overview]
Message-ID: <Pine.LNX.4.58L.0401282157530.4345@logos.cnet> (raw)
In-Reply-To: <20040128214356.GA8999@kroah.com>


Hi Greg!

On Wed, 28 Jan 2004, Greg KH wrote:

> On Wed, Jan 28, 2004 at 05:42:11PM -0200, Marcelo Tosatti wrote:
> >
> > - Mark pci_device_id list with __devinitdata
>
> Noooo!!!   I think we've finally audited all uses of this.  Do not do
> this please, it is wrong for 2.6.

[root@yage wan]# pwd
/root/linux-2.6.1/drivers/net/wan
[root@yage wan]# grep __devexit_p *
dscc4.c:  .remove = __devexit_p(dscc4_remove_one),
farsync.c:  .remove = __devexit_p(fst_remove_one),

So this ones are wrong too I assume?

Mind explaining me what is the deal with __devexit_p() in 2.6?

> > - Add #ifdef DEBUG around debug printk()
>
> What's wrong with dev_dbg()?  It gives you a much better idea of which
> device is spitting out the messages.

Indeed, dev_dbg() is fine. I will replace all #ifdef DEBUG entries in the
driver with dev_dgb(...). Thanks for the hint.

Linus, hold the patch :)



  reply	other threads:[~2004-01-29  0:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-28 19:42 Marcelo Tosatti
2004-01-28 21:21 ` Christoph Hellwig
2004-01-29  0:06   ` Marcelo Tosatti
2004-01-29  8:16     ` Christoph Hellwig
2004-01-29  9:02     ` Russell King
2004-01-29 13:02       ` Russell King
2004-01-28 21:43 ` Greg KH
2004-01-29  0:02   ` Marcelo Tosatti [this message]
2004-01-30 17:52 Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58L.0401282157530.4345@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®