From: Jesper Juhl <juhl-lkml@dif.dk>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Oliver Neukum <oliver@neukum.name>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>, Adrian Bunk <bunk@fs.tum.de>
Subject: [PATCH] fix gcc 3.4 inlining errors in drivers/scsi/dc395x.c
Date: Sun, 1 Aug 2004 14:02:50 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.60.0408011355080.2535@dragon.hygekrogen.localhost> (raw)
drivers/scsi/dc395x.c fails to build in 2.6.8-rc2-mm1 with gcc 3.4.0 with
the following errors :
drivers/scsi/dc395x.c: In function `dc395x_handle_interrupt':
drivers/scsi/dc395x.c:388: sorry, unimplemented: inlining failed in call to 'enable_msgout_abort': function body not available
drivers/scsi/dc395x.c:1740: sorry, unimplemented: called from here
drivers/scsi/dc395x.c: In function `msgin_set_async':
drivers/scsi/dc395x.c:394: sorry, unimplemented: inlining failed in call to 'set_xfer_rate': function body not available
drivers/scsi/dc395x.c:2677: sorry, unimplemented: called from here
The patch below fixes the build by un-inlining the functions (an
alternative would be to rework the file so the functions move before their
first use). As for 'set_xfer_rate' the function itself was not declared
inline, only the prototype.
Patch against 2.6.8-rc2-mm1
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -up linux-2.6.8-rc2-mm1-orig/drivers/scsi/dc395x.c linux-2.6.8-rc2-mm1/drivers/scsi/dc395x.c
--- linux-2.6.8-rc2-mm1-orig/drivers/scsi/dc395x.c 2004-07-31 13:09:46.000000000 +0200
+++ linux-2.6.8-rc2-mm1/drivers/scsi/dc395x.c 2004-07-31 23:22:47.000000000 +0200
@@ -384,13 +384,13 @@ static void scsi_reset_detect(struct Ada
static void pci_unmap_srb(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb);
static void pci_unmap_srb_sense(struct AdapterCtlBlk *acb,
struct ScsiReqBlk *srb);
-static inline void enable_msgout_abort(struct AdapterCtlBlk *acb,
+static void enable_msgout_abort(struct AdapterCtlBlk *acb,
struct ScsiReqBlk *srb);
static void srb_done(struct AdapterCtlBlk *acb, struct DeviceCtlBlk *dcb,
struct ScsiReqBlk *srb);
static void request_sense(struct AdapterCtlBlk *acb, struct DeviceCtlBlk *dcb,
struct ScsiReqBlk *srb);
-static inline void set_xfer_rate(struct AdapterCtlBlk *acb,
+static void set_xfer_rate(struct AdapterCtlBlk *acb,
struct DeviceCtlBlk *dcb);
static void waiting_timeout(unsigned long ptr);
@@ -2604,7 +2604,7 @@ static inline void msgin_reject(struct A
/* abort command */
-static inline void enable_msgout_abort(struct AdapterCtlBlk *acb,
+static void enable_msgout_abort(struct AdapterCtlBlk *acb,
struct ScsiReqBlk *srb)
{
srb->msgout_buf[0] = ABORT;
--
Jesper Juhl <juhl-lkml@dif.dk>
next reply other threads:[~2004-08-01 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 12:02 Jesper Juhl [this message]
2004-08-01 14:15 ` Adrian Bunk
2004-08-01 14:45 ` Jesper Juhl
2004-08-01 14:57 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0408011355080.2535@dragon.hygekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=akpm@osdl.org \
--cc=aliakc@web.de \
--cc=bunk@fs.tum.de \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®