From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S269148AbUHaUQL@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S269148AbUHaUQL (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 31 Aug 2004 16:16:11 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267505AbUHaUPO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 31 Aug 2004 16:15:14 -0400
Received: from mail.dif.dk ([193.138.115.101]:24748 "EHLO mail.dif.dk")
	by vger.kernel.org with ESMTP id S268985AbUHaUMQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Aug 2004 16:12:16 -0400
Date: Tue, 31 Aug 2004 22:18:10 +0200 (CEST)
From: Jesper Juhl <juhl-lkml@dif.dk>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, digilnux@dgii.com,
       linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.6.9-rc1-mm2: char/pcxx.c doesn't compile
In-Reply-To: <20040831174102.GF3466@fs.tum.de>
Message-ID: <Pine.LNX.4.61.0408312215240.2702@dragon.hygekrogen.localhost>
References: <20040830235426.441f5b51.akpm@osdl.org> <20040831174102.GF3466@fs.tum.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Aug 2004, Adrian Bunk wrote:

>  static void pcxxpoll(unsigned long dummy)
>  {
> @@ -1995,6 +1982,7 @@
>  	volatile struct board_chan *bc;
>  	unsigned long flags;
>  	int mflag = 0;
> +	int mstat;
>  
>  	if(ch)
>  		bc = ch->brdchan;
> @@ -2069,6 +2057,7 @@
>  	pcxxparam(tty,ch);
>  	memoff(ch);
>  	restore_flags(flags);
> +	return 0;
>  }

since pcxxpoll is declared with a void return, return 0; here seems 
pointless. A simple return;  or just falling off the end of the function 
should be fine as far as I can see.


--
Jesper Juhl <juhl-lkml@dif.dk>