From: Petko Manolov <petkan@nucleusys.com>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>,
eric.valette@free.fr, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed
Date: Fri, 10 Sep 2004 12:34:54 +0300 (EEST) [thread overview]
Message-ID: <Pine.LNX.4.61.0409101212420.22115@bender.nucleusys.com> (raw)
In-Reply-To: <20040909223605.GA17655@kroah.com>
On Thu, 9 Sep 2004, Greg KH wrote:
> On Thu, Sep 09, 2004 at 03:24:54PM -0700, Andrew Morton wrote:
>> Eric Valette <eric.valette@free.fr> wrote:
>>>
>>> Here is a small patch that makes the card functionnal again. I've
>>> forwarded the patch to driver author also.
>>>
>>> --- linux/drivers/usb/net/rtl8150.c-2.6.9-rc1-mm4.orig 2004-09-09 11:15:11.000000000 +0200
>>> +++ linux/drivers/usb/net/rtl8150.c 2004-09-09 11:15:46.000000000 +0200
>>> @@ -341,7 +341,7 @@
>>>
>>> static int rtl8150_reset(rtl8150_t * dev)
>>> {
>>> - u8 data = 0x11;
>>> + u8 data = 0x10;
>>
>> hm, OK. Presumably the change (which comes in via the bk-usb tree) was
>> made for a reason. So I suspect both versions are wrong ;)
>>
>> But it might be risky for Greg to merge this patch up at present.
>
> As all your patch does is revert the patch in my tree (it was a one line
> change), mainline should work just fine for you, right?
>
> I'll defer to Petkan as to what to do about this, as he sent me that
> patch for a good reason I imagine :)
Steven Hein <ssh@sgi.com> sent me a patch that supposedly fix device
registers misinitialization when it is being frequently reseted.
RTL8150 is quite flaky piece of HW so i first tested the new value and it
did work for me. That's why i decided to send it to Greg.
I would say lets wait for some time and see if we'll break someone else's
heart and then reverse the patch. Another solution is to restore the
original value and add new module parameter, so whoever thinks
anything != 0x10 work better for him will be free to change it.
Petko
next prev parent reply other threads:[~2004-09-10 9:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 13:24 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver Eric Valette
2004-09-07 13:30 ` Eric Valette
2004-09-09 9:42 ` 2.6.9-rc1-mm4 badness in rtl8150.c ethernet driver : fixed Eric Valette
2004-09-09 22:24 ` Andrew Morton
2004-09-09 22:36 ` Greg KH
2004-09-10 6:45 ` Eric Valette
2004-09-10 9:34 ` Petko Manolov [this message]
2004-09-10 11:05 ` Eric Valette
2004-09-10 11:54 ` Petko Manolov
2004-09-11 17:29 ` rtl8150.c ethernet driver : usb_unlink_urb ->usb_kill_urb Eric Valette
2004-09-11 17:33 ` Eric Valette
2004-09-14 18:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0409101212420.22115@bender.nucleusys.com \
--to=petkan@nucleusys.com \
--cc=akpm@osdl.org \
--cc=eric.valette@free.fr \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®