From: Jesper Juhl <juhl-lkml@dif.dk>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Stephen Hemminger <shemminger@osdl.org>,
Nico Schottelius <nico-kernel@schottelius.org>
Subject: [PATCH] add sysfs attribute 'carrier' for net devices
Date: Mon, 27 Sep 2004 00:51:09 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.61.0409270041460.2886@dragon.hygekrogen.localhost> (raw)
Hi,
Here's a patch that adds a new sysfs attribute for net devices. The new
attribute 'carrier' exposes the result of netif_carrier_ok() so that when
a network device has carrier the attribute value is 1 and when there is no
carrier the attribute value is 0.
Very rellevant attribute for network devices in my oppinion, and sysfs is
the logical place for it.
I've tested this only on my own machine, but I get the expected results:
With network cable plugged into eth0 :
juhl@dragon:~$ cat /sys/class/net/eth0/carrier
1
juhl@dragon:~$
With network cable unplugged :
juhl@dragon:~$ cat /sys/class/net/eth0/carrier
0
juhl@dragon:~$
Please review and consider applying.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -u linux-2.6.9-rc2-bk5-orig/net/core/net-sysfs.c linux-2.6.9-rc2-bk5/net/core/net-sysfs.c
--- linux-2.6.9-rc2-bk5-orig/net/core/net-sysfs.c 2004-09-14 23:19:53.000000000 +0200
+++ linux-2.6.9-rc2-bk5/net/core/net-sysfs.c 2004-09-27 00:24:01.000000000 +0200
@@ -126,8 +126,21 @@
return -EINVAL;
}
+static ssize_t show_carrier(struct class_device *dev, char *buf)
+{
+ struct net_device *net = to_net_dev(dev);
+ if (netif_running(net)) {
+ if (netif_carrier_ok(net))
+ return snprintf(buf, 3, "%d\n", 1);
+ else
+ return snprintf(buf, 3, "%d\n", 0);
+ }
+ return -EINVAL;
+}
+
static CLASS_DEVICE_ATTR(address, S_IRUGO, show_address, NULL);
static CLASS_DEVICE_ATTR(broadcast, S_IRUGO, show_broadcast, NULL);
+static CLASS_DEVICE_ATTR(carrier, S_IRUGO, show_carrier, NULL);
/* read-write attributes */
NETDEVICE_SHOW(mtu, fmt_dec);
@@ -186,6 +199,7 @@
&class_device_attr_type,
&class_device_attr_address,
&class_device_attr_broadcast,
+ &class_device_attr_carrier,
NULL
};
next reply other threads:[~2004-09-26 22:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041021112750.GN15294@schottelius.org>
[not found] ` <Pine.LNX.4.61.0410221744500.15769@jjulnx.backbone.dif.dk>
[not found] ` <Pine.LNX.4.61.0410231216110.3151@dragon.hygekrogen.localhost>
2004-09-26 22:51 ` Jesper Juhl [this message]
2004-09-27 17:29 ` Stephen Hemminger
2004-09-28 11:18 ` Jesper Juhl
2004-09-28 19:23 ` [PATCH] add sysfs attribute 'carrier' for net devices - try 2 Jesper Juhl
2004-09-28 19:22 ` Stephen Hemminger
2004-09-28 20:54 ` Nico Schottelius
2004-09-28 22:24 ` Stephen Hemminger
2004-09-29 6:54 ` Nico Schottelius
2004-09-28 12:10 ` [PATCH] add sysfs attribute 'carrier' for net devices Paulo Marques
2004-09-28 16:09 ` Martin Waitz
2004-10-23 18:49 ` Nico Schottelius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0409270041460.2886@dragon.hygekrogen.localhost \
--to=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nico-kernel@schottelius.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®