mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <juhl-lkml@dif.dk>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: Lista Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.9-rc4
Date: Mon, 11 Oct 2004 16:43:43 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0410111632360.26100@dragon.hygekrogen.localhost> (raw)
In-Reply-To: <1097504290l.6177l.1l@werewolf.able.es>


On Mon, 11 Oct 2004, J.A. Magallon wrote:

> Hi...
> 
> Lets polish it... I get this warnings on build:
> 
>  CC      fs/binfmt_elf.o
> fs/binfmt_elf.c: In function `padzero':
> fs/binfmt_elf.c:113: warning: ignoring return value of `clear_user', declared
> with attribute warn_unused_result
> include/asm/uaccess.h: In function `create_elf_tables':
> fs/binfmt_elf.c:175: warning: ignoring return value of `__copy_to_user',
> declared with attribute warn_unused_result
> fs/binfmt_elf.c:273: warning: ignoring return value of `copy_to_user',
> declared with attribute warn_unused_result
> fs/binfmt_elf.c: In function `load_elf_binary':
> fs/binfmt_elf.c:758: warning: ignoring return value of `clear_user', declared
> with attribute warn_unused_result
> fs/binfmt_elf.c: In function `fill_psinfo':
> fs/binfmt_elf.c:1226: warning: ignoring return value of `copy_from_user',
> declared with attribute warn_unused_result
> 
I've submitted a patch for review for the above (which seems to have 
fallen into a black hole). Search the archives for 
"[PATCH][Please review] fix various missing return value checks in binfmt_elf"
I see there's another proposed patch by "ramsez" - mail with topic "[FIX]: 
fs/binfmt_elf.c compilation warns"

I've also submitted a fix for the last one of those binfmt_elf warnings as 
a sepperate patch - search for 
"[PATCH] small binfmt_elf warning fix (copy_from_user return value checking)"


>  CC [M]  drivers/ieee1394/raw1394.o
> include/asm/uaccess.h: In function `raw1394_read':
> drivers/ieee1394/raw1394.c:446: warning: ignoring return value of
> `__copy_to_user', declared with attribute warn_unused_result
> 

This one I recently posted a patch for. Search for the thread with subject 
"[PATCH] check copy_to_user return value in raw1394"


I'll try submitting them again post 2.6.9 final, I've been re-reading them 
and I guess they could be done better. But if the warnings bug you too 
much, then they are in the archives and it certainly wouldn't hurt that 
they got some testing :)


--
Jesper Juhl



  reply	other threads:[~2004-10-11 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-11 14:18 J.A. Magallon
2004-10-11 14:43 ` Jesper Juhl [this message]
2004-10-12  4:45 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0410111632360.26100@dragon.hygekrogen.localhost \
    --to=juhl-lkml@dif.dk \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®