From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Karsten Keil <kkeil@suse.de>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
isdn4linux@listserv.isdn4linux.de
Subject: [PATCH] Elsa ISDN: Kill warnings if !PCI
Date: Sun, 24 Oct 2004 13:14:47 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.61.0410241311120.27282@anakin> (raw)
Elsa ISDN: Kill warnings if !PCI
I'm not 100% sure this is correct, though. Can setup_elsa() be called multiple
times? If yes, dev_qs[13]000 have to be static.
--- linux-2.6.10-rc1/drivers/isdn/hisax/elsa.c.orig 2004-10-23 10:33:02.000000000 +0200
+++ linux-2.6.10-rc1/drivers/isdn/hisax/elsa.c 2004-10-24 12:54:59.000000000 +0200
@@ -834,9 +834,6 @@ probe_elsa(struct IsdnCardState *cs)
return (CARD_portlist[i]);
}
-static struct pci_dev *dev_qs1000 __devinitdata = NULL;
-static struct pci_dev *dev_qs3000 __devinitdata = NULL;
-
#ifdef __ISAPNP__
static struct isapnp_device_id elsa_ids[] __initdata = {
{ ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133),
@@ -1022,6 +1019,9 @@ setup_elsa(struct IsdnCard *card)
cs->irq);
} else if (cs->typ == ISDN_CTYPE_ELSA_PCI) {
#ifdef CONFIG_PCI
+ struct pci_dev *dev_qs1000 = NULL;
+ struct pci_dev *dev_qs3000 = NULL;
+
cs->subtyp = 0;
if ((dev_qs1000 = pci_find_device(PCI_VENDOR_ID_ELSA,
PCI_DEVICE_ID_ELSA_MICROLINK, dev_qs1000))) {
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
reply other threads:[~2004-10-24 11:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0410241311120.27282@anakin \
--to=geert@linux-m68k.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®