From: Henrik Nordstrom <hno@marasystems.com>
To: Pablo Neira <pablo@eurodev.net>
Cc: Patrick McHardy <kaber@trash.net>,
Matthias Andree <matthias.andree@gmx.de>,
linux-net@vger.kernel.org, netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [BK PATCH] Fix ip_conntrack_amanda data corruption bug that breaks amanda dumps
Date: Fri, 5 Nov 2004 23:24:05 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.61.0411052320490.2017@filer.marasystems.com> (raw)
In-Reply-To: <418BE156.4020400@eurodev.net>
On Fri, 5 Nov 2004, Pablo Neira wrote:
> Patrick, what about this? this way we save a copy to a buffer for linear
> skbs.
You need to make sure you or any of the later string match/extract
functions are not reading outside of the skb, after the current data
segment.
>From what I could tell this was missing in your proposed change. If the
helper sees a packet with a C as last byte it would read past the end of
the skb, and without looking at the whole source I see it very likely
there is operations on the data further down assuming a null terminated
string..
Regards
Henrik
prev parent reply other threads:[~2004-11-05 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 12:15 Matthias Andree
2004-11-04 18:55 ` Patrick McHardy
2004-11-04 20:45 ` Herbert Xu
2004-11-04 21:00 ` David S. Miller
2004-11-04 21:53 ` Patrick McHardy
2004-11-04 23:50 ` Matthias Andree
2004-11-04 23:59 ` Patrick McHardy
2004-11-04 23:17 ` Matthias Andree
2004-11-04 23:53 ` Patrick McHardy
2004-11-05 0:06 ` David S. Miller
2004-11-05 0:40 ` Patrick McHardy
2004-11-05 1:04 ` Matthias Andree
2004-11-05 0:58 ` David S. Miller
2004-11-05 11:30 ` Matthias Andree
2004-11-05 20:23 ` Pablo Neira
2004-11-05 22:19 ` Patrick McHardy
2004-11-06 1:53 ` Pablo Neira
2004-11-07 12:16 ` Matthias Andree
2004-11-07 16:39 ` Patrick McHardy
2004-11-05 22:24 ` Henrik Nordstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0411052320490.2017@filer.marasystems.com \
--to=hno@marasystems.com \
--cc=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=matthias.andree@gmx.de \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®